Skip to content

Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikepapadim merged 2 commits into from
May 4, 2026
+5 −5
Merged

Update TornadoVM dependency for jdk21 and fixed suffix regarding future releases #111

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfda8a1
[chore] Update TornadoVM dependency to jdk21 and fixed suffix for ong…
stratika Apr 30, 2026
89f21e6
[chore] Update suffix within default properties of jdk21 in pom file
stratika May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<properties>
<!-- CI-friendly version: resolved by flatten-maven-plugin at build time -->
<revision>0.4.0</revision>
<tornadovm.base.version>4.0.0</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) -->
<tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) -->
<jdk.version.suffix></jdk.version.suffix> <!-- JDK Suffix: empty=JDK21, -jdk25=JDK25 -->
<tornadovm.version>${tornadovm.base.version}</tornadovm.version> <!-- Default: JDK21 (no suffix) -->
Copy link

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default properties still define jdk.version.suffix as empty and tornadovm.version as the unsuffixed base version. With the new TornadoVM naming described in the PR (4.0.1-* includes -jdk21/-jdk25), this means builds where the JDK profiles don’t activate will try to resolve io.github.beehive-lab:tornado-*:${tornadovm.base.version} (no suffix). Consider making the defaults consistent with the new scheme (e.g., default jdk.version.suffix to -jdk21 and define tornadovm.version as ${tornadovm.base.version}${jdk.version.suffix}), and update the inline comments accordingly.

Suggested change
<tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without jdk suffix) -->
<jdk.version.suffix></jdk.version.suffix> <!-- JDK Suffix: empty=JDK21, -jdk25=JDK25 -->
<tornadovm.version>${tornadovm.base.version}</tornadovm.version> <!-- Default: JDK21 (no suffix) -->
<tornadovm.base.version>4.0.1</tornadovm.base.version> <!-- TornadoVM base version (without JDK suffix) -->
<jdk.version.suffix>-jdk21</jdk.version.suffix> <!-- Default JDK suffix: -jdk21; overridden to -jdk25 by the JDK25 profile -->
<tornadovm.version>${tornadovm.base.version}${jdk.version.suffix}</tornadovm.version> <!-- Default TornadoVM version follows the suffixed artifact naming scheme -->

Copilot uses AI. Check for mistakes.
<!-- Compiler defaults (overridden by JDK profiles below) -->
Expand Down Expand Up @@ -146,8 +146,8 @@
<properties>
<maven.compiler.source>21</maven.compiler.source>
<maven.compiler.target>21</maven.compiler.target>
<!-- JDK21 default - no jdk suffix needed -->
<tornadovm.version>${tornadovm.base.version}</tornadovm.version>
<jdk.version.suffix>-jdk21</jdk.version.suffix>
<tornadovm.version>${tornadovm.base.version}${jdk.version.suffix}</tornadovm.version>
</properties>
Comment thread
stratika marked this conversation as resolved.
<build>
<plugins>
Expand Down
Loading