[fix] Normalization compute step for non-nvidia hardware#84
Merged
mikepapadim merged 2 commits intomainfrom Dec 11, 2025
Merged
[fix] Normalization compute step for non-nvidia hardware#84mikepapadim merged 2 commits intomainfrom
mikepapadim merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a conditional finalization step for RMS normalization operations to support non-NVIDIA hardware. The fix ensures proper normalization computation across different GPU vendors by adding a hardware-specific final reduction step when needed.
- Adds conditional
reductionFinalNormalizationtask after initial RMS reduction - Uses
shouldUseFinalNormalization()to determine when the additional step is required - Applies the fix consistently across multiple model architectures and quantization formats
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Qwen3Q8_0FFNLayers.java | Adds conditional finalization task for attention RMS normalization in Q8_0 quantized Qwen3 model |
| Phi3Q8_0FFNLayers.java | Adds conditional finalization task for attention RMS normalization in Q8_0 quantized Phi3 model |
| Qwen3FP16FFNLayers.java | Adds conditional finalization task for attention RMS normalization in FP16 Qwen3 model |
| Qwen2FP16FFNLayers.java | Adds conditional finalization task for attention RMS normalization in FP16 Qwen2 model |
| Phi3FP16FFNLayers.java | Adds conditional finalization task for attention RMS normalization in FP16 Phi3 model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/org/beehive/gpullama3/tornadovm/layers/type/q8_0/Phi3Q8_0FFNLayers.java
Outdated
Show resolved
Hide resolved
orionpapadakis
approved these changes
Dec 11, 2025
…/Phi3Q8_0FFNLayers.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.