Skip to content

Commit 1c2ad9f

Browse files
authored
Merge pull request #3 from beekeeper-studio/fix/isNaN
use Number.isNaN as it's more robust
2 parents f9d3c0c + 1da3c31 commit 1c2ad9f

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/js/modules/Format/defaults/formatters/money.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export default function(cell, formatterParams, onRendered){
1010
var after = !!formatterParams.symbolAfter;
1111
var precision = typeof formatterParams.precision !== "undefined" ? formatterParams.precision : 2;
1212

13-
if(isNaN(floatVal)){
13+
if(Number.isNaN(floatVal)){
1414
return this.emptyToSpace(this.sanitizeHTML(cell.getValue()));
1515
}
1616

@@ -41,4 +41,4 @@ export default function(cell, formatterParams, onRendered){
4141
}else{
4242
return after ? sign + value + symbol : sign + symbol + value;
4343
}
44-
}
44+
}

src/js/modules/Format/defaults/formatters/star.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default function(cell, formatterParams, onRendered){
1717
star.setAttribute("xml:space", "preserve");
1818
star.style.padding = "0 1px";
1919

20-
value = value && !isNaN(value) ? parseInt(value) : 0;
20+
value = value && !Number.isNaN(value) ? parseInt(value) : 0;
2121

2222
value = Math.max(0, Math.min(value, maxStars));
2323

@@ -35,4 +35,4 @@ export default function(cell, formatterParams, onRendered){
3535
element.setAttribute("aria-label", value);
3636

3737
return stars;
38-
}
38+
}

src/js/modules/Format/defaults/formatters/traffic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default function(cell, formatterParams, onRendered){
77
color = "#666666",
88
percent, percentValue;
99

10-
if(isNaN(value) || typeof cell.getValue() === "undefined"){
10+
if(Number.isNaN(value) || typeof cell.getValue() === "undefined"){
1111
return;
1212
}
1313

@@ -44,4 +44,4 @@ export default function(cell, formatterParams, onRendered){
4444
el.style.backgroundColor = color;
4545

4646
return el;
47-
}
47+
}

0 commit comments

Comments
 (0)