smartplaylist: Fix existing tests after CLI overhaul

Author: JOJ0

test/plugins/test_smartplaylist.py

@@ -14,7 +14,7 @@
 
 # TODO: Tests in this fire are very bad. Stop using Mocks in this module.
 
-from os import path, remove
+import os
 from pathlib import Path
 from shutil import rmtree
 from tempfile import mkdtemp
@@ -171,9 +171,9 @@ def test_playlist_update(self):
         spl = SmartPlaylistPlugin()
 
         i = Mock(path=b"/tagada.mp3")
-        i.evaluate_template.side_effect = lambda pl, _: pl.replace(
-            b"$title", b"ta:ga:da"
-        ).decode()
+        i.evaluate_template.side_effect = lambda pl, *_: os.fsdecode(
+            pl
+        ).replace("$title", "ta:ga:da")
 
         lib = Mock()
         lib.replacements = CHAR_REPLACE
@@ -212,10 +212,9 @@ def test_playlist_update_output_extm3u(self):
         type(i).title = PropertyMock(return_value="fake title")
         type(i).length = PropertyMock(return_value=300.123)
         type(i).path = PropertyMock(return_value=b"/tagada.mp3")
-        i.evaluate_template.side_effect = lambda pl, _: pl.replace(
-            b"$title",
-            b"ta:ga:da",
-        ).decode()
+        i.evaluate_template.side_effect = lambda pl, *_: os.fsdecode(
+            pl
+        ).replace("$title", "ta:ga:da")
 
         lib = Mock()
         lib.replacements = CHAR_REPLACE
@@ -262,10 +261,9 @@ def test_playlist_update_output_extm3u_fields(self):
         type(i).path = PropertyMock(return_value=b"/tagada.mp3")
         a = {"id": 456, "genres": ["Rock", "Pop"]}
         i.__getitem__.side_effect = a.__getitem__
-        i.evaluate_template.side_effect = lambda pl, _: pl.replace(
-            b"$title",
-            b"ta:ga:da",
-        ).decode()
+        i.evaluate_template.side_effect = lambda pl, *_: os.fsdecode(
+            pl
+        ).replace("$title", "ta:ga:da")
 
         lib = Mock()
         lib.replacements = CHAR_REPLACE
@@ -308,9 +306,9 @@ def test_playlist_update_uri_format(self):
         i = MagicMock()
         type(i).id = PropertyMock(return_value=3)
         type(i).path = PropertyMock(return_value=b"/tagada.mp3")
-        i.evaluate_template.side_effect = lambda pl, _: pl.replace(
-            b"$title", b"ta:ga:da"
-        ).decode()
+        i.evaluate_template.side_effect = lambda pl, *_: os.fsdecode(
+            pl
+        ).replace("$title", "ta:ga:da")
 
         lib = Mock()
         lib.replacements = CHAR_REPLACE
@@ -471,10 +469,9 @@ def test_playlist_update_dest_regen(self):
         )
         # Set a path which would be equal to the one returned by `item.destination`.
         type(i).destination = PropertyMock(return_value=lambda: b"/tagada.mp3")
-        i.evaluate_template.side_effect = lambda pl, _: pl.replace(
-            b"$title",
-            b"ta:ga:da",
-        ).decode()
+        i.evaluate_template.side_effect = lambda pl, *_: os.fsdecode(
+            pl
+        ).replace("$title", "ta:ga:da")
 
         lib = Mock()
         lib.replacements = CHAR_REPLACE