A subset of review comments from @snejus:

- Renamed id to _id
- Aligned line breaks for some comment with actual ruff line length
- Removed comment dividers
- Removed a number of unnecessary or duplicate comments

Author: semohr

beetsplug/tidal/__init__.py

@@ -36,11 +36,6 @@
 
 
 class TidalPlugin(MetadataSourcePlugin):
-    """Tidal metadata plugin.
-
-    Allows to fetch metadata candidates from tidal.
-    """
-
     def __init__(self) -> None:
         super().__init__()
 
@@ -168,8 +163,6 @@ def item_candidates(
         log.debug("Found {0} candidates", len(candidates))
         return candidates
 
-    # ---------------------------------- Search ---------------------------------- #
-
     @staticmethod
     def _item_queries(item: Item) -> Iterable[str]:
         """Search queries for items."""
@@ -272,9 +265,8 @@ def search_tracks_by_ids(
             if item["type"] == "artists"
         }
 
-        # Yield for IDs first
-        for id in _ids:
-            if id is not None and (track := track_lookup.get(id)):
+        for _id in _ids:
+            if _id is not None and (track := track_lookup.get(_id)):
                 yield self._get_track_info(track, artist_lookup=artist_lookup)
             else:
                 yield None
@@ -339,9 +331,8 @@ def search_albums_by_ids(
             if item["type"] == "artists"
         }
 
-        # Yield for IDs first
-        for id in _ids:
-            if id is not None and (album := album_lookup.get(id)):
+        for _id in _ids:
+            if _id is not None and (album := album_lookup.get(_id)):
                 yield self._get_album_info(
                     album,
                     track_lookup=track_lookup,
@@ -365,8 +356,6 @@ def search_albums_by_ids(
                 else:
                     yield None
 
-    # ---------------------------------- Parsing --------------------------------- #
-
     def _get_album_info(
         self,
         album: TidalAlbum,
@@ -413,7 +402,6 @@ def _get_track_info(
         track: TidalTrack,
         artist_lookup: dict[str, TidalArtist],
     ) -> TrackInfo:
-        # Artists are sorted in the track relationship
         artist_names, artist_ids = self._extract_artists(
             track["relationships"]["artists"]["data"],
             artist_lookup,
@@ -441,9 +429,8 @@ def _extract_artists(
     ) -> tuple[list[str], list[str]]:
         """Extract artists from a relationship.
 
-        Needed because artists are ordered in the track relationship,
-        while the included response data is accessed by id via
-        ``artist_lookup``.
+        Artists are sorted in the track/album response relationship but not in the
+        track/album responses included items.
         """
         artist_names = []
         artist_ids = []
@@ -462,9 +449,8 @@ def _extract_artists(
     @staticmethod
     def _extract_title(attributes: AlbumAttributes | TrackAttributes):
         """
-        Tidal UIs append the version string at the end of the
-        title. We do the same here by formatting it as
-        ``"{title} ({version})"`` to stay consistent.
+        Tidal UIs append the version string at the end of the title. We do the same here
+        by formatting it as ``"{title} ({version})"`` to stay consistent.
         """
         if version := attributes.get("version"):
             return f"{attributes['title']} ({version})"

beetsplug/tidal/api_types.py

@@ -4,8 +4,6 @@
 
 from typing_extensions import NotRequired
 
-# ----------------------------------- Core ----------------------------------- #
-
 
 class ResourceIdentifier(TypedDict):
     id: str
@@ -36,9 +34,6 @@ class Copyright(TypedDict):
     text: str
 
 
-# -------------------------------- Attributes -------------------------------- #
-
-
 class ArtistAttributes(TypedDict):
     name: str
     popularity: float  # 0.0 - 1.0, required
@@ -130,9 +125,6 @@ class SearchAttributes(TypedDict):
     trackingId: str
 
 
-# --------------------------------- Resources -------------------------------- #
-
-
 class TidalArtist(TypedDict):
     id: str
     type: Literal["artists"]
@@ -172,5 +164,3 @@ class Document(TypedDict, Generic[T]):
 AlbumDocument = Document[list[TidalAlbum]]
 TrackDocument = Document[list[TidalTrack]]
 SearchDocument = Document[TidalSearch]
-
-# ----------------------------------- Search ---------------------------------- #

test/plugins/test_tidal.py

@@ -21,7 +21,6 @@
     )
 
 
-# --------------------------------- Mock Data -------------------------------- #
 def _make_artist(id: str, name: str) -> TidalArtist:
     return {
         "id": id,