Fix typing issues

Author: snejus

beetsplug/musicbrainz.py

@@ -379,17 +379,17 @@ def track_info(
             if r["type"] == "remixer"
         ] or None
 
-        if recording.get("length"):
-            info.length = int(recording["length"]) / 1000.0
+        if length := recording["length"]:
+            info.length = length / 1000.0
 
         info.trackdisambig = recording.get("disambiguation")
 
         if recording.get("isrcs"):
             info.isrc = ";".join(recording["isrcs"])
 
-        lyricists = []
-        composer = []
-        composer_sort = []
+        lyricists: list[str] = []
+        composers: list[str] = []
+        composer_sort: list[str] = []
         for work_relation in recording.get("work_relations", ()):
             if work_relation["type"] != "performance":
                 continue
@@ -406,14 +406,14 @@ def track_info(
                     if type == "lyricist":
                         lyricists.append(artist_relation["artist"]["name"])
                     elif type == "composer":
-                        composer.append(artist_relation["artist"]["name"])
+                        composers.append(artist_relation["artist"]["name"])
                         composer_sort.append(
                             artist_relation["artist"]["sort_name"]
                         )
         if lyricists:
             info.lyricists = lyricists
-        if composer:
-            info.composers = composer
+        if composers:
+            info.composers = composers
             info.composer_sort = ", ".join(composer_sort)
 
         arrangers = []
@@ -547,8 +547,8 @@ def album_info(self, release: Release) -> AlbumInfo:
 
                     ti.artists_ids = _artist_ids(track["artist_credit"])
                     ti.artist_id = ti.artists_ids[0]
-                if track.get("length"):
-                    ti.length = int(track["length"]) / (1000.0)
+                if length := track["length"]:
+                    ti.length = length / 1000.0
 
                 track_infos.append(ti)
 
@@ -614,7 +614,7 @@ def album_info(self, release: Release) -> AlbumInfo:
 
         # Release events.
         info.country, release_date = _preferred_release_event(release)
-        release_group_date = release["release_group"].get("first_release_date")
+        release_group_date = release["release_group"]["first_release_date"]
         if not release_date:
             # Fall back if release-specific date is not available.
             release_date = release_group_date
@@ -682,9 +682,11 @@ def album_info(self, release: Release) -> AlbumInfo:
                         url_source.capitalize(),
                     )
 
-            for source, url in urls.items():
+            for source_name, url in urls.items():
                 setattr(
-                    info, f"{source}_album_id", extract_release_id(source, url)
+                    info,
+                    f"{source}_album_id",
+                    extract_release_id(source_name, url),
                 )
 
         extra_albumdatas = plugins.send("mb_album_extract", data=release)