Skip tests that fail due to Windows path handling

Author: snejus

beets/test/_common.py

@@ -19,6 +19,10 @@
 if TYPE_CHECKING:
     import pytest
 
+# Because the absolute path begins with something like C:, we
+# can't disambiguate it from an ordinary query.
+WIN32_NO_IMPLICIT_PATHS = "Implicit paths are not supported on Windows"
+
 beetsplug.__path__ = [
     os.path.abspath(
         os.path.join(

test/dbcore/test_query.py

@@ -31,10 +31,6 @@
 from beets.library import Item
 from beets.test import _common
 
-# Because the absolute path begins with something like C:, we
-# can't disambiguate it from an ordinary query.
-WIN32_NO_IMPLICIT_PATHS = "Implicit paths are not supported on Windows"
-
 _p = pytest.param
 
 
@@ -378,7 +374,9 @@ def test_relative(self, lib, helper):
 
         assert {i.title for i in lib.items(q)} == {"relative item"}
 
-    @pytest.mark.skipif(sys.platform == "win32", reason=WIN32_NO_IMPLICIT_PATHS)
+    @pytest.mark.skipif(
+        sys.platform == "win32", reason=_common.WIN32_NO_IMPLICIT_PATHS
+    )
     @pytest.mark.parametrize(
         "q, expected_titles",
         [
@@ -416,7 +414,9 @@ def test_case_sensitivity(
 
     # FIXME: Also create a variant of this test for windows, which tests
     # both os.sep and os.altsep
-    @pytest.mark.skipif(sys.platform == "win32", reason=WIN32_NO_IMPLICIT_PATHS)
+    @pytest.mark.skipif(
+        sys.platform == "win32", reason=_common.WIN32_NO_IMPLICIT_PATHS
+    )
     @pytest.mark.parametrize(
         "q, is_path_query",
         [

test/dbcore/test_queryparse.py

@@ -1,9 +1,12 @@
 """Tests for dbcore query parsing helpers."""
 
+import sys
+
 import pytest
 
 from beets.dbcore import ModelQuery, query, sort
 from beets.dbcore.queryparse import QueryTerm
+from beets.test._common import WIN32_NO_IMPLICIT_PATHS
 from beets.test.fixtures import ModelFixture1, SortFixture
 
 _p = pytest.param
@@ -26,12 +29,25 @@ class TestQueryTermParsing:
             ("test:", ("test", "", query.SubstringQuery)),
             (r":regexp", (None, "regexp", query.RegexpQuery)),
             (r"test::regexp", ("test", "regexp", query.RegexpQuery)),
-            (r"test\:val", (None, "test:val", query.SubstringQuery)),
+            _p(
+                r"test\:val",
+                (None, "test:val", query.SubstringQuery),
+                marks=pytest.mark.skipif(
+                    sys.platform == "win32",
+                    reason="Backslash is parsed as a path separator in Windows",
+                ),
+            ),
             (r":test\:regexp", (None, "test:regexp", query.RegexpQuery)),
             ("year:1999", ("year", "1999", query.NumericQuery)),
             ("year:1999..2010", ("year", "1999..2010", query.NumericQuery)),
             ("", (None, "", query.SubstringQuery)),
-            ("/tmp", ("path", "/tmp", query.PathQuery)),
+            _p(
+                "/tmp",
+                ("path", "/tmp", query.PathQuery),
+                marks=pytest.mark.skipif(
+                    sys.platform == "win32", reason=WIN32_NO_IMPLICIT_PATHS
+                ),
+            ),
         ],
     )
     def test_query_term_parsing(self, query_string, expected):