fix: mbpseudo issues when applying pseudorelease by MartinCa · Pull Request #6512 · beetbox/beets

MartinCa · 2026-04-09T08:35:18Z

Description

I have not created an issue for this but I tried to use mbpseudo to apply this pseudorelease: https://musicbrainz.org/release/6c100fef-6abf-41c4-bd21-6f9becaaab6c

When doing that I encountered two errors as seen below, this PR should fix those issues. The second issue was only apparent once the first issue was fixed.

Sending event: import_task_choice
Traceback (most recent call last):
  File "/lsiopy/bin/beet", line 6, in <module>
    sys.exit(main())
             ^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/ui/__init__.py", line 1013, in main
    _raw_main(args)
  File "/lsiopy/lib/python3.12/site-packages/beets/ui/__init__.py", line 992, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/lsiopy/lib/python3.12/site-packages/beets/ui/commands/import_/__init__.py", line 131, in import_func
    import_files(lib, byte_paths, query)
  File "/lsiopy/lib/python3.12/site-packages/beets/ui/commands/import_/__init__.py", line 75, in import_files
    session.run()
  File "/lsiopy/lib/python3.12/site-packages/beets/importer/session.py", line 237, in run
    pl.run_parallel(QUEUE_SIZE)
  File "/lsiopy/lib/python3.12/site-packages/beets/util/pipeline.py", line 471, in run_parallel
    raise exc_info[1].with_traceback(exc_info[2])
  File "/lsiopy/lib/python3.12/site-packages/beets/util/pipeline.py", line 336, in run
    out = self.coro.send(msg)
          ^^^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/util/pipeline.py", line 195, in coro
    task = func(*args, task)
           ^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/importer/stages.py", line 217, in user_query
    _apply_choice(session, task)
  File "/lsiopy/lib/python3.12/site-packages/beets/importer/stages.py", line 323, in _apply_choice
    task.apply_metadata()
  File "/lsiopy/lib/python3.12/site-packages/beets/importer/tasks.py", line 263, in apply_metadata
    self.match.apply_metadata()
  File "/lsiopy/lib/python3.12/site-packages/beets/autotag/hooks.py", line 609, in apply_metadata
    for item, data in self.merged_pairs:
                      ^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/autotag/hooks.py", line 603, in merged_pairs
    (i, ti.merge_with_album(self.info))
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/autotag/hooks.py", line 482, in merge_with_album
    album = album_info.raw_data
            ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/functools.py", line 998, in __get__
    val = self.func(instance)
          ^^^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/autotag/hooks.py", line 301, in raw_data
    data = {**super().raw_data}
              ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/functools.py", line 998, in __get__
    val = self.func(instance)
          ^^^^^^^^^^^^^^^^^^^
  File "/lsiopy/lib/python3.12/site-packages/beets/autotag/hooks.py", line 176, in raw_data
    data = self.__class__(**self.copy())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: PseudoAlbumInfo.__init__() missing 2 required positional arguments: 'pseudo_release' and 'official_release'

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/martin/personal/src-ext/beets/beets/__main__.py", line 24, in <module>
    main(sys.argv[1:])
    ~~~~^^^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/ui/__init__.py", line 1013, in main
    _raw_main(args)
    ~~~~~~~~~^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/ui/__init__.py", line 992, in _raw_main
    subcommand.func(lib, suboptions, subargs)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/ui/commands/import_/__init__.py", line 131, in import_func
    import_files(lib, byte_paths, query)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/ui/commands/import_/__init__.py", line 75, in import_files
    session.run()
    ~~~~~~~~~~~^^
  File "/home/martin/personal/src-ext/beets/beets/importer/session.py", line 237, in run
    pl.run_parallel(QUEUE_SIZE)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/util/pipeline.py", line 471, in run_parallel
    raise exc_info[1].with_traceback(exc_info[2])
  File "/home/martin/personal/src-ext/beets/beets/util/pipeline.py", line 336, in run
    out = self.coro.send(msg)
  File "/home/martin/personal/src-ext/beets/beets/util/pipeline.py", line 195, in coro
    task = func(*args, task)
  File "/home/martin/personal/src-ext/beets/beets/importer/stages.py", line 217, in user_query
    _apply_choice(session, task)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/importer/stages.py", line 326, in _apply_choice
    task.add(session.lib)
    ~~~~~~~~^^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/importer/tasks.py", line 503, in add
    self.album = lib.add_album(self.imported_items())
                 ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/library/library.py", line 83, in add_album
    item.add(self)
    ~~~~~~~~^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/library/models.py", line 84, in add
    super().add(lib)
    ~~~~~~~~~~~^^^^^
  File "/home/martin/personal/src-ext/beets/beets/dbcore/db.py", line 717, in add
    self.store()
    ~~~~~~~~~~^^
  File "/home/martin/personal/src-ext/beets/beets/library/models.py", line 74, in store
    super().store(fields)
    ~~~~~~~~~~~~~^^^^^^^^
  File "/home/martin/personal/src-ext/beets/beets/dbcore/db.py", line 659, in store
    tx.mutate(
    ~~~~~~~~~^
        f"INSERT INTO {self._flex_table} "
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<2 lines>...
        (self.id, key, value),
        ^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/martin/personal/src-ext/beets/beets/dbcore/db.py", line 1039, in mutate
    return self.db._connection().execute(statement, subvals).lastrowid
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
sqlite3.ProgrammingError: Error binding parameter 3: type 'dict' is not supported

[ x ] ~~Documentation.~~
[ x ] Changelog.
[ x ] Tests.

Copilot

Pull request overview

This PR fix mbpseudo crash when user pick pseudo-release during import. It make PseudoAlbumInfo.raw_data work with new Info.raw_data behavior, and it stop bad dict data from leaking into item/album flex fields.

Changes:

Override PseudoAlbumInfo.raw_data to build plain AlbumInfo for raw export, so no TypeError from self.__class__(**self.copy()).
Fix _adjust_final_album_match to write new mapping to match.mapping (not into album_info dict data).
Add regression tests and changelog entry for both crash cases.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
beetsplug/mbpseudo.py	Fix raw_data construction for `PseudoAlbumInfo` and fix mapping update target.
test/plugins/test_mbpseudo.py	Add regression tests for raw_data and mapping leak to prevent sqlite bind crash.
docs/changelog.rst	Document both fixed crashes for users.

codecov · 2026-04-09T08:41:12Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@1d01689). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #6512   +/-   ##
=========================================
  Coverage          ?   71.16%           
=========================================
  Files             ?      150           
  Lines             ?    19160           
  Branches          ?     3085           
=========================================
  Hits              ?    13636           
  Misses            ?     4864           
  Partials          ?      660

Files with missing lines	Coverage Δ
beetsplug/mbpseudo.py	`84.81% <100.00%> (ø)`

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

snejus

Looks good - just simplify the changelog note to a higher-level description.

snejus · 2026-04-14T23:21:18Z

Thanks!

MartinCa added 3 commits April 9, 2026 06:41

fix(mbpseudo): override raw_data to avoid TypeError on apply

fa0fe4f

fix(mbpseudo): update match mapping instead of storing on AlbumInfo

ee1d643

fix(mbpseudo): add regression test for fix and changelog

0e97b27

MartinCa requested review from a team and asardaes as code owners April 9, 2026 08:35

Copilot AI review requested due to automatic review settings April 9, 2026 08:35

github-actions bot added the mbpseudo mbpseudo plugin label Apr 9, 2026

Copilot started reviewing on behalf of MartinCa April 9, 2026 08:35 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

Merge branch 'master' into fix/mbpseudo-raw-data

7434833

snejus requested changes Apr 14, 2026

View reviewed changes

Comment thread docs/changelog.rst Outdated

MartinCa added 3 commits April 15, 2026 01:05

Merge branch 'beetbox:master' into fix/mbpseudo-raw-data

0ff0fc8

docs: simplify changelog

ca69f00

docs: fix formatting

fd19e5c

snejus approved these changes Apr 14, 2026

View reviewed changes

snejus enabled auto-merge April 14, 2026 23:21

Merge branch 'master' into fix/mbpseudo-raw-data

9d64f00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: mbpseudo issues when applying pseudorelease#6512

fix: mbpseudo issues when applying pseudorelease#6512
MartinCa wants to merge 8 commits intobeetbox:masterfrom
MartinCa:fix/mbpseudo-raw-data

MartinCa commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

codecov bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

snejus left a comment

Uh oh!

Uh oh!

snejus commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MartinCa commented Apr 9, 2026

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

codecov bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

snejus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

snejus commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Apr 9, 2026 •

edited

Loading