-
Notifications
You must be signed in to change notification settings - Fork 2k
Tidal Metadata Plugin #6520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Tidal Metadata Plugin #6520
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
cc943c3
Scafolded tidal source plugin:
semohr b55c860
Added small typing wrapper for api layer. Not enterly needed but it m…
semohr c0000d9
Added the *_by_id capabilities for TidalPlugin.
semohr 70a3a7a
Renamed Album, Track, Artists to TidalAlbum, TidalTrack, TidalArtist
semohr 4d6fc99
Added a number of unit tests for the parsing.
semohr b77bc1a
Fixed a few typing issues and a small bug around how responses are ha…
semohr a85de2d
Implemented batch lookup methods for more efficient retrieval.
semohr a1f07f7
Refactored slightly and move search into own methods
semohr 1569810
Added candidate method implementations methods: Required a slight
semohr 137662a
Added changelog entry
semohr dd58cc8
Added documentation.
semohr 996d2ea
First iteration of reviews:
semohr 90e02be
Added tests for candidates and item_candidates.
semohr a585df5
Added batching for max filter size.
semohr 199d846
Added state verify step in authentication function. Not that is neede…
semohr ad79dc2
super requests already raises.
semohr 615bf91
Ignore types files in coverage.
semohr b9949cc
A subset of review comments from @snejus:
semohr 2c24b93
Another subset of review comments from @snejus:
semohr 2afa774
Move auth flow to use requests-oauth.
semohr 2908372
Added a few tests for the RateLimitAdapter
semohr 634b128
Added tests for the id extractor.
semohr 830c14a
Added retry logic to TidalSession and added RequestHandler abstraction
semohr 815dce4
renamed hashmaps to *_by_id from *_lookup
semohr 55da1cb
Use get_json where applicable and simplified iso 8601 parsing.
semohr 7509fca
Moved beets ui import to top.
semohr 0568cc0
Enabled strict typing.
semohr aa18e2e
Auth flow should open browser if possible.
semohr eaf1f00
warning instead of raising errors.
semohr aa17a50
Changelog entry moved to unrelease section
semohr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.