Preserve pyc files in distributed artefacts.#262
Closed
freakboy3742 wants to merge 2 commits intomainfrom
Closed
Conversation
Member
Author
|
Ok... artefact size goes from 47MB to 129MB, so... that's a little too big. Stripping only |
Member
|
Perhaps it would make more sense to leave the PYC compilation to the app build tool (e.g. beeware/briefcase#2073). We previously talked about this in the context of the app's own code, but it could apply equally to the standard library. And once a given support package has been compiled, the result can be cached and reused across multiple apps. |
Member
Author
|
Yeah - I had a similar thought. Some other things that occurred to me:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although PYC files were being stripped to save space, it turns out it's significantly faster at runtime to have PYCs cached for use. This removes the
__pycache__exclusion from packaged artefacts.PR Checklist: