Skip to content

start persian side and work on home page#516

Closed
AmirMohammadDehghan wants to merge 1 commit intobeeware:lektorfrom
AmirMohammadDehghan:Amir-M-Dehghan
Closed

start persian side and work on home page#516
AmirMohammadDehghan wants to merge 1 commit intobeeware:lektorfrom
AmirMohammadDehghan:Amir-M-Dehghan

Conversation

@AmirMohammadDehghan
Copy link
Copy Markdown

@AmirMohammadDehghan AmirMohammadDehghan commented Mar 9, 2023

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@AmirMohammadDehghan
Copy link
Copy Markdown
Author

Hello i am starting add persian language to beeware site and it is my first trying i worked on home page and translate it

@freakboy3742 freakboy3742 added the preview Approved for an automated preview label Mar 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 61c5475):

https://beeware-org--pr516-amir-m-dehghan-6ke7j24q.web.app

(expires Fri, 17 Mar 2023 00:11:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec

@AmirMohammadDehghan
Copy link
Copy Markdown
Author

This show is very interesting and I will try to translate as much as possible

@johnzhou721
Copy link
Copy Markdown
Contributor

@freakboy3742 This looks nice but has been stale -- I don't know Persian, but should we merge this after trimming whitespace such that more people can help translate?

@freakboy3742 freakboy3742 added preview Approved for an automated preview and removed preview Approved for an automated preview labels May 8, 2025
@freakboy3742
Copy link
Copy Markdown
Member

I seem to recall at the time that I didn't merge this because the preview didn't actually do anything - it added content, but not enough content that Persian became an option on the translation menu. I've just tried to rebuild the preview, and it looks like it's sufficiently stale that it no longer builds at all.

On that basis, my inclination is to close this PR. I'm happy to re-open if someone wants to revive a Persian translation.

johnzhou721 added a commit to johnzhou721/beeware.github.io that referenced this pull request Jul 3, 2025
Co-authored-by: AmiMohammad Dehghan <ad9191386@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Approved for an automated preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants