fix Stray 'None' in Tutorial Entries#625
Conversation
|
@freakboy3742 Hope that this hint doesn't give away too much stuff. Clarification (might contain spoilers, but I tried not to)I didn't look at those files (line-by-line / search) yet (but I do know that it stores the strings from when I first looked at and scrolled through the source of the website). My wording in the review was sort of vague, but I don't know specifically and don't want to know specifically what's going on (so other contribers can do more digging), but there probably should be a word at the place of None (and I suspected that there might be a field holding it in the databags) so that's why I left that comment.I just reworded my comment to be more clear. |
|
Visit the preview URL for this PR (updated for commit 8b55c53): https://beeware-org--pr625-lektor-j3fkbigc.web.app (expires Tue, 27 May 2025 02:21:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec |
|
@freakboy3742 This is a little bit not right... I broadly know where the issue is but as I mentioned in the clarification I'm refusing to dig deeper (so I can leave this issue to the sprinters to figure out). |
|
Checking on the above suggestions made |
|
@johnzhou721 I just saw why the statement was resulting in However, I would still suggest having a second fallback. I am pushing the change in a bit based on the above suggestions. |
|
Sorry I do not have access to GitHub right now -- so replying via email and
can't submit a review.
Clarifications:
- I'm not affiliated with BeeWare; I'm just trying to help with those
things as a worker bee from Texas.
- Talk with @freakboy3742 (or anyone in the Bee Team) about having a second
fallback; I have no opinion on that.
- Otherwise, LGT*M*.
…On Mon, May 19, 2025 at 10:39 PM Velda Kiara ***@***.***> wrote:
@VeldaKiara <https://github.com/VeldaKiara> requested your review on: #625
<#625> fix Stray 'None'
in Tutorial Entries.
—
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BRODAI3UO3DGRGATA4PEHQT27KPWTAVCNFSM6AAAAAB5O5GJDGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXG4ZDKMRRGY4TEMI>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
freakboy3742
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the fix!
|
OK so I think there's more translation fields in the databag file you
fixed... I think we should see if those also have similar typos.
…On Tue, May 20, 2025 at 9:55 AM Russell Keith-Magee < ***@***.***> wrote:
Merged #625 <#625> into
lektor.
—
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BRODAIZVXZOMMJ5J2NUHRTT27M65NAVCNFSM6AAAAAB5O5GJDGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJXG4ZTMMZRGQYDMMQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
The change is an add-on in case the default value of this line
default(bag(bag_name, alt_default, key)fails which is what was causing theNoneentry on docs.It eliminates having
Noneon this issue and on other future news entries.Fixes issue 622
PR Checklist: