Miscellaneous fixups to text & templates#675
Conversation
|
Ready for review + merge. Rest assured I have forced Weblate to commit. EDIT Do not merge yet. I plan on finding more issues after supper. |
…der of words (Translations in Contributing)
|
@freakboy3742 Apply preview as I have added a check to see just link the video is not embeddable to prevent black squares on the page. Talking about |
|
(EDITED, too many changes...) Summary of changes:
Apply preview and verify those changes before merging this Pull Request. EDIT apologies for so many trivial changes. |
|
I've also made the video link display a link icon + the title of the video, and also adjusted PyPI's full form. |
|
Visit the preview URL for this PR (updated for commit 44013cb): https://beeware-org--pr675-patch-17-0dmt0y60.web.app (expires Fri, 04 Jul 2025 13:13:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b0da44bc067e7d9a4255c77cb2c5fce572218cec |
freakboy3742
left a comment
There was a problem hiding this comment.
A couple of minor tweaks, but mostly looks good.
|
DO NOT MERGE — unembedsable video links aren’t showing up |
Committed into wrong branch, correcting
|
After much of using codespaces on a phone on a bus this is working! |
|
Fixed bug where Donate is not highlighted in the top bar in the membership page! Sorry, I kept trying to convince myself to let it go and finalize this, but I keep finding more bugs, and they always bother me. Anyways, please apply preview when it's convenient. So: This is ready for re-review. I will edit the list of changes. |
|
Done updating changelog.
Imagine if Website had towncrier... |
freakboy3742
left a comment
There was a problem hiding this comment.
One clarification, but otherwise looks like a good set of cleanups.
There's no problem adding more fixes as you find them - but each time you add a fix to a PR that was 95% there, the PR gets a little further from being merged.
I'll do another preview and final review once the last issue is resolved.
|
You’re welcome and if this was the only thing you were working on, sorry for having you stay up until 11pm just to merge this. |
DO NOT MERGE. Will collect several more here.
PR Checklist: