Fix desktop icon association in GNOME#41
Merged
freakboy3742 merged 1 commit intoOct 24, 2025
Conversation
freakboy3742
approved these changes
Oct 24, 2025
freakboy3742
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix - definitely an oversight, and explains the odd behavior of system icons not appearing... given I thought we'd fixed that problem :-)
Contributor
Author
|
No problem! Thanks for the great software! I used it to build personal apps that I use daily. It's the most useful thing ever. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the Linux system template in line with the AppImage template, which received this fix in beeware/briefcase-linux-appimage-template#10.
Without
StartupWMClassin the.desktopfile, the application icon does not appear when the program is running in GNOME. This same thing happened to Signal Desktop on my system and when I saw signalapp/Signal-Desktop#7515, I realized we could fix it here too.This PR adds
StartupWMClass={{ cookiecutter.app_name }}to the desktop file template. Testing on Ubuntu 24.04 with GNOME 46 confirmed that{{ cookiecutter.app_name }}(e.g.,my-app) works correctly, while{{ cookiecutter.formal_name }}(e.g.,My App) does not. I'm not sure why we needapp_nameinstead offormal_namebut this works on my system.PR Checklist: