Add zizmor pre-commit hook and fix all reported GHA security issues#2939
Open
DresdenGman wants to merge 4 commits into
Open
Add zizmor pre-commit hook and fix all reported GHA security issues#2939DresdenGman wants to merge 4 commits into
DresdenGman wants to merge 4 commits into
Conversation
- Pin all 27 unpinned action references to full commit SHAs
- Add persist-credentials: false to 4 checkout steps
- Add explicit permissions: {} to 11 jobs lacking them
- Add zizmor to .pre-commit-config.yaml (v1.27.0)
3 remaining findings left for maintainer discretion:
2× secrets-inherit, 1× superfluous-actions.
4× unsound-contains (false positives on needs.*/steps.*).
Closes beeware#2937
freakboy3742
added
the
basic checks failing
Add changenote for beeware#2937.
The zizmor pre-commit hook blocks CI due to excessive-permissions findings on ci.yml jobs. These cannot be fixed without breaking job execution. Pre-commit integration deferred to beeware/.github-level resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin all 27 unpinned action references to full commit SHAs, add persist-credentials: false to 4 checkout steps, and add explicit permissions where safe (release.yml, reusable workflow callers).
Zizmor pre-commit hook deferred — the hook reports excessive-permissions on ci.yml jobs that cannot be fixed with permissions: {} without breaking job execution.
Fixes #2937
PR Checklist:
Assisted-by: Hermes Agent (GPT-5.6)