feat: implement safe response handling to manage Content-Length header for binary responses

Author: jeffleyd

src/debug.php

@@ -33,6 +33,33 @@ function ddless_log(string $msg): void {
 
 ddless_log("[ddless] debug.php loaded, DEBUG_MODE=" . (getenv('DDLESS_DEBUG_MODE') ?: 'not set') . "\n");
 
+function ddless_safe_send_response($response): void {
+    if (php_sapi_name() !== 'cli-server') {
+        $response->send();
+        return;
+    }
+
+    $isBinary = $response instanceof \Symfony\Component\HttpFoundation\BinaryFileResponse;
+
+    if ($isBinary) {
+        $file = $response->getFile();
+        $content = file_get_contents($file->getPathname());
+        $response->headers->set('Content-Type', $response->headers->get('Content-Type'));
+        foreach ($response->headers->allPreserveCase() as $name => $values) {
+            if (strtolower($name) === 'content-length') continue;
+            foreach ((array) $values as $v) {
+                header("{$name}: {$v}", strtolower($name) !== 'set-cookie');
+            }
+        }
+        http_response_code($response->getStatusCode());
+        header('Content-Length: ' . strlen($content));
+        echo $content;
+    } else {
+        $response->headers->remove('Content-Length');
+        $response->send();
+    }
+}
+
 // PHP 7.4 compatibility polyfills for PHP 8.0+ string functions
 if (!function_exists('str_starts_with')) {
     function str_starts_with(string $haystack, string $needle): bool {

src/frameworks/laravel/http_request.php

@@ -655,8 +655,7 @@ function ddless_response_status_text(int $statusCode): ?string
             echo $capturedBodyContent;
         }
     } else {
-        $response->headers->remove('Content-Length');
-        $response->send();
+        ddless_safe_send_response($response);
         if (is_string($responseBodyContent)) {
             $capturedBodyContent = $responseBodyContent;
         }

src/frameworks/symfony/http_request.php

@@ -580,8 +580,7 @@ function ddless_response_status_text(int $statusCode): ?string
             echo $capturedBodyContent;
         }
     } else {
-        $response->headers->remove('Content-Length');
-        $response->send();
+        ddless_safe_send_response($response);
         if (is_string($responseBodyContent)) {
             $capturedBodyContent = $responseBodyContent;
         }

src/frameworks/tempest/http_request.php

@@ -671,13 +671,13 @@ function ddless_response_status_text(int $statusCode): ?string
             echo $responseBodyContent;
         }
     } else {
-        // Non-CLI: send response directly
         if (is_object($response) && method_exists($response, 'send')) {
-            ob_start();
-            $response->send();
-            header_remove('Content-Length');
-            $bodyOutput = ob_get_clean();
-            $capturedBodyContent = is_string($bodyOutput) ? $bodyOutput : $responseBodyContent;
+            if (function_exists('ddless_safe_send_response')) {
+                ddless_safe_send_response($response);
+            } else {
+                $response->send();
+            }
+            $capturedBodyContent = $responseBodyContent;
         } else {
             if (is_string($responseBodyContent)) {
                 echo $responseBodyContent;