Sourcery refactored main branch#43
Conversation
| # Compute SER | ||
| ser = sent_error_count / counter if counter > 0 else 0.0 | ||
| print('Sentence count: {}'.format(counter)) | ||
| print(f'Sentence count: {counter}') |
There was a problem hiding this comment.
Function main refactored with the following changes:
- Replace call to format with f-string. (
use-fstring-for-formatting)
| if tag == 'insert': | ||
| for i in range(j1, j2): | ||
| word = seq2[i] | ||
| insertion_table[word] += 1 | ||
| elif tag == 'delete': | ||
| if tag == 'delete': | ||
| for i in range(i1, i2): | ||
| word = seq1[i] | ||
| deletion_table[word] += 1 | ||
| deletion_table[seq1[i]] += 1 | ||
| elif tag == 'insert': | ||
| for i in range(j1, j2): | ||
| insertion_table[seq2[i]] += 1 |
There was a problem hiding this comment.
Function track_confusions refactored with the following changes:
- Simplify conditional into switch-like form (
switch) - Inline variable that is only used once (
inline-variable)
| # For insertions and deletions, put a filler of '***' on the other one, and | ||
| # make the other all caps |
There was a problem hiding this comment.
Function print_diff refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend) - Replace unused for index with underscore (
for-index-underscore) - Replace range(0, x) with range(x) (
remove-zero-from-range)
This removes the following comments ( why? ):
# For insertions and deletions, put a filler of '***' on the other one, and
# More complicated logic for a substitution
# make the other all caps
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.68%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!