Skip to content

Commit 53405bd

Browse files
rodrigoaguileraflavioheleno
authored andcommitted
Skip publish code coverage on PRs.
1 parent 66e039d commit 53405bd

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

.github/workflows/continuous-integration.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,3 +69,4 @@ jobs:
6969
coverageCommand: composer run-script test-coverage
7070
coverageLocations: |
7171
${{github.workspace}}/clover.xml:clover
72+
if: github.event_name != 'pull_request'

src/Docker.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,11 @@ public function systemEvents(array $queryParameters = [], string $fetch = self::
8787
return $this->executeEndpoint(new SystemEvents($queryParameters), $fetch);
8888
}
8989

90-
public static function create($httpClient = null, array $additionalPlugins = [], array $additionalNormalizers = []) : self
90+
public static function create(
91+
$httpClient = null,
92+
array $additionalPlugins = [],
93+
array $additionalNormalizers = []
94+
) : self
9195
{
9296
if (null === $httpClient) {
9397
$httpClient = DockerClientFactory::createFromEnv();

tests/Resource/ContainerResourceTest.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ public function testAttach(): void
6161

6262
public function testAttachWebsocket(): void
6363
{
64-
$this->markTestSkipped('Since docker API 1.28 Websockets are binary so this test needs work. See https://github.com/xtermjs/xterm.js/issues/883');
64+
$this->markTestSkipped('Since docker API 1.28 Websockets are binary so this test needs work. ' .
65+
'See https://github.com/xtermjs/xterm.js/issues/883');
6566
$containerConfig = new ContainersCreatePostBody();
6667
$containerConfig->setImage('busybox:latest');
6768
$containerConfig->setCmd(['sh']);
@@ -109,7 +110,9 @@ public function testAttachWebsocket(): void
109110

110111
public function testLogs(): void
111112
{
112-
$this->markTestSkipped('Since at least 1.43 docker API does not return a `application/vnd.docker.raw-stream` but a `application/vnd.docker.multiplexed-stream` so this needs review. See https://github.com/beluga-php/docker-php/issues/19');
113+
$this->markTestSkipped('Since at least 1.43 docker API does not return a `application/vnd.docker.raw-stream` ' .
114+
'but a `application/vnd.docker.multiplexed-stream` so this needs review. '.
115+
'See https://github.com/beluga-php/docker-php/issues/19');
113116
$containerConfig = new ContainersCreatePostBody();
114117
$containerConfig->setImage('busybox:latest');
115118
$containerConfig->setCmd(['echo', '-n', 'output']);

0 commit comments

Comments
 (0)