[major] BEM-XJST: modifier templates should apply before def()

[miripiruni]

Fixes #482

[coveralls]

Coverage remained the same at 99.306% when pulling 020fa6a on issue-482__mod-templates into ba102b7 on master.

[miripiruni]

Looks like it’s patch… but I still have doubt about it.

[qfox]

except

[miripiruni]

@zxqfox thanks!

[qfox]

Looks good!

[coveralls]

Coverage remained the same at 99.387% when pulling e542cd7 on issue-482__mod-templates into e76cd62 on master.

[miripiruni]

I want to check it on real front-end project with gemini tests. @tadatuta @zxqfox @sbmaxx who uses v8.x?

[sbmaxx]

Turbo? ;)

[miripiruni]

@zxqfox it’s a major changes.

Integration tests are red. https://nda.ya.ru/3TwoUQ

Template from turbo:

block('list')(
    def()((node, ctx) => applyNext({ items: [].concat(ctx.content || []) })),

    addMods()((node, ctx) => {
        const mods = { [ctx.ordered ? 'ordered' : 'unordered']: true };

        ctx.ordered && node.items.length > 10 && (mods['wide-numbers'] = true);

        // у ВинФонов в шрифтах нет некоторых символов, используемых для маркеров
        if ((node.data.reqdata.device_detect.OSFamily || '').toLowerCase() === 'windowsphone') {
            mods['alt-markers'] = true;
        }

        return mods;
    }),

    …

[qfox]

Okay, let's consider this as breaking, but it's a bad code on their side, they can't guarantee they have items in node cuz there is no applyNext call.

😢 but true.

[miripiruni]

PR is locked and waiting next major release.