ci: add GitHub Actions workflow#26
Merged
Merged
Conversation
Runs typecheck, lint, tests, and build on Node 20 and 22. format:check is deliberately omitted until existing prettier failures are fixed.
The prettier failures are fixed in #25, which should merge first.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3436db7a31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
package.json declares engines.node >=18, and all runtime and dev dependencies support 18, so CI should exercise it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/ci.ymlso PRs and pushes tomainget automated checks (previously the repo had no CI, so contributor PRs showed zero status checks).What it runs — on Node 20 and 22 (
ubuntu-latest, npm cache):npm cinpm run format:check(unblocked by style: format with prettier #25)npm run ci— typecheck + lint + testnpm run buildDetails:
fail-fast: falseso one Node version failing doesn't cancel the otherpermissionsand aconcurrencygroup that cancels superseded runs on the same refThis PR's own checks exercise the workflow.