fix for workflows

Author: igorbenav

.github/workflows/tests.yml

@@ -7,10 +7,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
 
     - name: Set up Python
-      uses: actions/setup-python@v4
+      uses: actions/setup-python@v5
       with:
         python-version: 3.11
 
@@ -21,7 +21,10 @@ jobs:
       run: uv venv
 
     - name: Install package with dev dependencies
-      run: uv pip install -e ".[dev,memcached]"
+      run: uv pip install -e ".[dev]"
 
     - name: Run tests
-      run: uv run pytest
+      run: uv run pytest
+      env:
+        ENVIRONMENT: local
+        SECRET_KEY: test-secret-key-for-testing-only

.github/workflows/type-checking.yml

@@ -24,4 +24,7 @@ jobs:
       run: uv pip install -e ".[dev]"
 
     - name: Run mypy
-      run: uv run mypy src --config-file pyproject.toml
+      run: uv run mypy src --config-file pyproject.toml
+      env:
+        ENVIRONMENT: local
+        SECRET_KEY: test-secret-key-for-testing-only

README.md

@@ -1838,13 +1838,13 @@ This project uses **fast unit tests** that don't require external services like
 
 ### 7.1 Writing Tests
 
-Create test files with the name `test_{entity}_unit.py` in the `tests/` folder, replacing `{entity}` with what you're testing:
+Create test files with the name `test_{entity}.py` in the `tests/` folder, replacing `{entity}` with what you're testing:
 
 ```sh
-touch tests/test_items_unit.py
+touch tests/test_items.py
 ```
 
-Follow the structure in `tests/test_user_unit.py` for examples. Our tests use:
+Follow the structure in `tests/test_user.py` for examples. Our tests use:
 
 - **pytest** with **pytest-asyncio** for async support
 - **unittest.mock** for mocking dependencies  

pyproject.toml

@@ -25,10 +25,12 @@ dependencies = [
     "pydantic-settings>=2.0.3",
     "redis>=5.0.1",
     "arq>=0.25.0",
-    "gunicorn>=22.0.0",
     "bcrypt>=4.1.1",
     "psycopg2-binary>=2.9.9",
     "fastcrud>=0.15.5",
+    "gunicorn>=23.0.0",
+    "ruff>=0.11.13",
+    "mypy>=1.16.0",
 ]
 
 [project.optional-dependencies]
@@ -38,6 +40,7 @@ dev = [
     "faker>=26.0.0",
     "mypy>=1.8.0",
     "types-redis>=4.6.0",
+    "ruff>=0.1.0",
 ]
 
 [build-system]

src/app/api/v1/tasks.py

@@ -1,7 +1,7 @@
 from typing import Any
 
 from arq.jobs import Job as ArqJob
-from fastapi import APIRouter, Depends
+from fastapi import APIRouter, Depends, HTTPException
 
 from ...api.dependencies import rate_limiter_dependency
 from ...core.utils import queue
@@ -24,7 +24,13 @@ async def create_task(message: str) -> dict[str, str]:
     dict[str, str]
         A dictionary containing the ID of the created task.
     """
-    job = await queue.pool.enqueue_job("sample_background_task", message)  # type: ignore
+    if queue.pool is None:
+        raise HTTPException(status_code=503, detail="Queue is not available")
+    
+    job = await queue.pool.enqueue_job("sample_background_task", message)
+    if job is None:
+        raise HTTPException(status_code=500, detail="Failed to create task")
+    
     return {"id": job.job_id}
 
 
@@ -42,6 +48,11 @@ async def get_task(task_id: str) -> dict[str, Any] | None:
     Optional[dict[str, Any]]
         A dictionary containing information about the task if found, or None otherwise.
     """
+    if queue.pool is None:
+        raise HTTPException(status_code=503, detail="Queue is not available")
+        
     job = ArqJob(task_id, queue.pool)
-    job_info: dict = await job.info()
-    return vars(job_info)
+    job_info = await job.info()
+    if job_info is None:
+        return None
+    return job_info.__dict__ if hasattr(job_info, '__dict__') else dict(job_info) if job_info else None