Remove unused sqlite and mysql settings#226
Merged
igorbenav merged 2 commits intobenavlabs:stagingfrom Nov 24, 2025
Merged
Conversation
Contributor
Author
Collaborator
|
awesome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment in the source code there are settings for mysql and sqlite, they are not used anywhere and also not mentioned in any part of the documentation, while the fact they are in the settings hints to the user that they would just work, at least that is how I would understand it if I see them already in the settings.
This PR removes the dead piece of code which can be confusing to a user. In addition it centralize the creation of the URL connection string in the code base