Skip to content

Use PowerShell instead of WMIC for system info on Windows #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mipaaa wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

Use PowerShell instead of WMIC for system info on Windows #482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/benchee/system.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ defmodule Benchee.System do
defp cpu_speed, do: cpu_speed(os())

defp cpu_speed(:Windows) do
parse_cpu_for(:Windows, system_cmd("WMIC", ["CPU", "GET", "NAME"]))
parse_cpu_for(:Windows, system_cmd("powershell", ["-Command", "(gcim Win32_Processor).Name"]))
end

defp cpu_speed(:macOS) do
Expand All @@ -133,10 +133,7 @@ defmodule Benchee.System do
@doc false
def parse_cpu_for(_, "N/A"), do: "N/A"

def parse_cpu_for(:Windows, raw_output) do
"Name" <> cpu_info = raw_output
String.trim(cpu_info)
end
def parse_cpu_for(:Windows, raw_output), do: String.trim(raw_output)

def parse_cpu_for(:macOS, raw_output), do: String.trim(raw_output)

Expand Down Expand Up @@ -167,7 +164,7 @@ defmodule Benchee.System do
defp available_memory(:Windows) do
parse_memory_for(
:Windows,
system_cmd("WMIC", ["COMPUTERSYSTEM", "GET", "TOTALPHYSICALMEMORY"])
system_cmd("powershell", ["-Command", "(gcim Win32_ComputerSystem).TotalPhysicalMemory"])
)
end

Expand Down