Skip to content

fix: use :: in pip+git requirement #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jolars merged 1 commit into from
Mar 26, 2026
Merged

fix: use :: in pip+git requirement #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions solvers/pgd_safe_screening.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ class Solver(BaseSolver):
name = "PGD_safe_screening"
sampling_strategy = "iteration"
install_cmd = "conda"
requirements = ["pip:git+https://github.com/c-elvira/slopescreening"]
# TODO when benchopt 1.7 is released, update to
# "pip::git+https://github.com/c-elvira/slopescreening"
requirements = ["pip::git+https://github.com/c-elvira/slopescreening"]

references = [
"C. Elvira and C. Herzet, “Safe rules for the identification of zeros in ",
Expand Down
4 changes: 1 addition & 3 deletions solvers/slope_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@ class Solver(BaseSolver):
name = "SlopePath"
sampling_strategy = "iteration"
install_cmd = "conda"
requirements = ["pip:git+https://github.com/jolars/slope-path"]
# TODO when benchopt 1.7 is released, update to
# "pip::git..."
requirements = ["pip::git+https://github.com/jolars/slope-path"]

references = [
"Dupuis, X., & Tardivel, P. (2024). The solution path of SLOPE. "
Expand Down
Loading