Update Auth.php#1566
Open
dgvirtual wants to merge 1 commit into
Open
Conversation
Remove trim function from the validation rules as "[CI4 validation never changes your data](https://codeigniter.com/user_guide/installation/upgrade_validations.html)".
Owner
|
We should still trim these in the app code right? |
Contributor
Author
|
I guess so, but trimming should be done before validation. If we validate untrimmed identity, for example, and the user happens to leave a space at the end, the identity will validate despite such identity already existing, right? |
Owner
|
Yep agreed |
|
need trim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove trim function from the validation rules as "CI4 validation never changes your data".