Skip to content

Don't abort dump --subprocesses on non-Python children#847

Open
ravwojdyla wants to merge 2 commits into
benfred:masterfrom
ravwojdyla:fixup-dump-process-non-python
Open

Don't abort dump --subprocesses on non-Python children#847
ravwojdyla wants to merge 2 commits into
benfred:masterfrom
ravwojdyla:fixup-dump-process-non-python

Conversation

@ravwojdyla
Copy link
Copy Markdown
Contributor

@ravwojdyla ravwojdyla commented May 1, 2026

  • dump --subprocesses aborts on first non-Python child instead of skipping #846

  • dump --subprocesses no longer aborts when a child isn't Python — bring it in line with record/top

  • swap PythonSpy::newPythonSpy::retry_new(..., 5) so a still-initializing child gets the same retry window the live samplers grant

  • catch errors from the recursive write_traces call and warn! instead of ?-propagating 1

  • hoist the parentpid != pid skip above the separator writeln! so grandchildren no longer print a stray ----

  • regression test: parent + python child + non-python sibling (sh -c 'sleep 3600'); asserts write_traces returns Ok, parent and python child appear, non-python child does not

Footnotes

  1. matches Sampler::new_subprocess_sampler in src/sampler.rs — invisible by default, visible with RUST_LOG=warn

@ravwojdyla
Copy link
Copy Markdown
Contributor Author

Build / Test Wheels (3.8.0, windows-latest) (pull_request)Failing after 13s

That looks flaky to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant