Don't abort dump --subprocesses on non-Python children#847
Open
ravwojdyla wants to merge 2 commits into
Open
Conversation
Contributor
Author
That looks flaky to me ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dump --subprocessesaborts on first non-Python child instead of skipping #846dump --subprocessesno longer aborts when a child isn't Python — bring it in line withrecord/topswap
PythonSpy::new→PythonSpy::retry_new(..., 5)so a still-initializing child gets the same retry window the live samplers grantcatch errors from the recursive
write_tracescall andwarn!instead of?-propagating 1hoist the
parentpid != pidskip above the separatorwriteln!so grandchildren no longer print a stray----regression test: parent + python child + non-python sibling (
sh -c 'sleep 3600'); assertswrite_tracesreturnsOk, parent and python child appear, non-python child does notFootnotes
matches
Sampler::new_subprocess_samplerinsrc/sampler.rs— invisible by default, visible withRUST_LOG=warn↩