Skip to content

fix: get_mach_cpu_type do not mutate imutable variable with raw pointers #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfred merged 1 commit into from
May 8, 2026
+4 −4
Merged

fix: get_mach_cpu_type do not mutate imutable variable with raw pointers #849

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/binary_parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ impl BinaryInfo {

#[cfg(target_os = "macos")]
fn get_mach_cpu_type() -> goblin::mach::cputype::CpuType {
let is_arm: i32 = 0;
let size: usize = std::mem::size_of_val(&is_arm);
let mut is_arm: i32 = 0;
let mut size: libc::size_t = size_of_val(&is_arm);
unsafe {
let name = std::ffi::CString::new("hw.optional.arm64").expect("CString::new failed");
let ret = libc::sysctlbyname(
name.as_ptr() as *const i8,
&is_arm as *const _ as *mut _,
&size as *const _ as *mut _,
&mut is_arm as *mut _ as *mut libc::c_void,
&mut size,
std::ptr::null_mut(),
0,
);
Expand Down
Loading