cointracker transactions src changes

Author: benjaminjnoack

src/apps/hdb/commands/coinbase/balances/coinbase-balances-handlers.ts

@@ -177,20 +177,6 @@ function getSignedDelta(row: CoinbaseTransactionRow): { asset: string; delta: nu
     case "Withdrawal":
     case "Send":
       return { asset, delta: unsigned * -1 };
-    case "Retail Staking Transfer":
-    case "Retail Unstaking Transfer":
-      // Paired internal transfers (+X and -X legs) that net to zero; exclude from balance
-      return { asset, delta: 0 };
-    case "Wrap Asset":
-      // ETH/ETH2 being wrapped into CBETH — reduces ETH holdings
-      if (asset === "ETH") {
-        return { asset: "ETH", delta: unsigned * -1 };
-      }
-      // CBETH received from wrapping — increases CBETH holdings
-      if (asset === "CBETH") {
-        return { asset: "CBETH", delta: unsigned };
-      }
-      throw new Error(`Unsure how to quantify delta for Wrap Asset of ${row.asset}`);
     case "Unwrap":
       if (asset === "ETH") {
         return { asset: "ETH", delta: unsigned };

src/apps/hdb/commands/cointracker/transactions/cointracker-transactions-handlers.ts

@@ -37,6 +37,9 @@ function toOptionalString(value: unknown): string | null {
 }
 
 function toRequiredString(value: unknown, field: string): string {
+  if (value instanceof Date) {
+    return value.toISOString();
+  }
   if (typeof value !== "string") {
     throw new Error(`cointracker transaction row missing ${field}`);
   }

src/apps/hdb/db/coinbase/transactions/coinbase-transactions-repository.ts

@@ -203,8 +203,7 @@ export async function insertCoinbaseTransactionsBatch(
   const sql = `
     INSERT INTO ${COINBASE_TRANSACTIONS_TABLE}
     (${INSERT_COLUMNS.join(", ")})
-    VALUES ${placeholders.join(", ")}
-    ON CONFLICT (id) DO NOTHING;
+    VALUES ${placeholders.join(", ")};
   `;
   await client.query(sql, values);
 }

src/apps/hdb/db/cointracker/balances/cointracker-balances-sql.ts

@@ -106,6 +106,21 @@ export const REBUILD_COINTRACKER_BALANCES_LEDGER_SQL = `
       1 AS row_order
     FROM ${COINTRACKER_TRANSACTIONS_TABLE} t
     WHERE t.sent_currency IS NOT NULL
+
+    UNION ALL
+
+    SELECT
+      t.fee_currency AS currency,
+      t.date,
+      t.transaction_id AS cointracker_transaction_id,
+      (0::numeric - COALESCE(t.fee_amount, 0)::numeric) AS delta,
+      0::numeric AS received_quantity,
+      0::numeric AS sent_quantity,
+      2 AS row_order
+    FROM ${COINTRACKER_TRANSACTIONS_TABLE} t
+    WHERE t.fee_currency IS NOT NULL
+      AND t.fee_amount IS NOT NULL
+      AND t.fee_amount::numeric > 0
   ),
   seeded AS (
     SELECT

src/apps/hdb/db/cointracker/transactions/cointracker-transactions-repository.ts

@@ -129,7 +129,8 @@ export async function insertCointrackerTransactionsBatch(
   const sql = `
     INSERT INTO ${COINTRACKER_TRANSACTIONS_TABLE}
     (${INSERT_COLUMNS.join(", ")})
-    VALUES ${placeholders.join(", ")};
+    VALUES ${placeholders.join(", ")}
+    ON CONFLICT (transaction_id) DO NOTHING;
   `;
   await client.query(sql, values);
 }