Switching off vintage test runner.

Author: benjaminkomen

build.gradle

@@ -57,7 +57,7 @@ dependencies {
 
     // Testing
     testImplementation "org.junit.jupiter:junit-jupiter-api:${junitVersion}"
-    testImplementation "org.junit.vintage:junit-vintage-engine:${junitVersion}"
+    testImplementation "org.junit.jupiter:junit-jupiter-engine:${junitVersion}"
     testImplementation 'org.mockito:mockito-core:4.2.0'
     testImplementation "org.hamcrest:hamcrest-core:2.2"
     testImplementation "io.mockk:mockk:1.12.1"

src/test/kotlin/com/wikia/tibia/objects/LootStatisticsItemTest.kt

@@ -2,7 +2,7 @@ package com.wikia.tibia.objects
 
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class LootStatisticsItemTest {
 

src/test/kotlin/com/wikia/tibia/objects/LootWrapperTest.kt

@@ -2,7 +2,7 @@ package com.wikia.tibia.objects
 
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class LootWrapperTest {
 

src/test/kotlin/com/wikia/tibia/objects/PercentageTest.kt

@@ -2,7 +2,7 @@ package com.wikia.tibia.objects
 
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Test
+import org.junit.jupiter.api.Test
 
 class PercentageTest {
 

src/test/kotlin/com/wikia/tibia/repositories/CreatureRepositoryTest.kt

@@ -5,8 +5,8 @@ import com.wikia.tibia.objects.Creature
 import io.vavr.control.Try
 import org.hamcrest.MatcherAssert
 import org.hamcrest.Matchers
-import org.junit.Before
-import org.junit.Test
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
 import org.mockito.Mock
 import org.mockito.Mockito.mock
 import org.mockito.Mockito.`when`
@@ -19,7 +19,7 @@ class CreatureRepositoryTest {
   private lateinit var creatureRepository: CreatureRepository
 
   @Suppress("UNCHECKED_CAST")
-  @Before
+  @BeforeEach
   fun setup() {
     creatureGateway = mock(WikiObjectGateway::class.java) as WikiObjectGateway<Creature>
     creatureRepository = CreatureRepository()

src/test/kotlin/com/wikia/tibia/repositories/LootRepositoryTest.kt

@@ -10,8 +10,8 @@ import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.instanceOf
 import org.hamcrest.Matchers.`is`
 import org.hamcrest.Matchers.nullValue
-import org.junit.Before
-import org.junit.Test
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Test
 import org.mockito.Mock
 import org.mockito.Mockito.mock
 import org.mockito.Mockito.`when`
@@ -22,7 +22,7 @@ internal class LootRepositoryTest {
   private lateinit var lootGateway: LootGateway
   private lateinit var lootRepository: LootRepository
 
-  @Before
+  @BeforeEach
   fun setup() {
     lootGateway = mock(LootGateway::class.java)
     lootRepository = LootRepository(lootGateway)

src/test/kotlin/com/wikia/tibia/usecases/BuildingRentsTest.kt

@@ -12,9 +12,9 @@ import com.wikia.tibia.repositories.InputRepository
 import io.vavr.control.Try
 import org.hamcrest.MatcherAssert.assertThat
 import org.hamcrest.Matchers.`is`
-import org.junit.Before
-import org.junit.Ignore
-import org.junit.Test
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
+import org.junit.jupiter.api.Test
 import org.mockito.ArgumentMatchers.anyBoolean
 import org.mockito.ArgumentMatchers.anyString
 import org.mockito.Mock
@@ -32,13 +32,13 @@ class BuildingRentsTest {
   private lateinit var buildingRepository: BuildingRepository
   private lateinit var target: BuildingRents
 
-  @Before
+  @BeforeEach
   fun setup() {
     inputRepository = mock(InputRepository::class.java)
     buildingRepository = mock(BuildingRepository::class.java)
   }
 
-  @Ignore
+  @Disabled
   @Test
   fun `should update rent to buildings - production`() {
     // given

src/test/kotlin/com/wikia/tibia/usecases/NullEditWikiObjectsTest.kt

@@ -17,15 +17,15 @@ import com.wikia.tibia.repositories.OutfitRepository
 import com.wikia.tibia.repositories.QuestRepository
 import com.wikia.tibia.repositories.SpellRepository
 import com.wikia.tibia.repositories.StreetRepository
-import org.junit.Before
-import org.junit.Ignore
-import org.junit.Test
+import org.junit.jupiter.api.BeforeEach
+import org.junit.jupiter.api.Disabled
+import org.junit.jupiter.api.Test
 
-@Ignore
+@Disabled
 class NullEditWikiObjectsTest {
   private lateinit var target: NullEditWikiObjects
 
-  @Before
+  @BeforeEach
   fun setup() {
     target = NullEditWikiObjects(
       achievementRepository = AchievementRepository(),