Add highlighting support for conditions#3
Open
martin-helmich wants to merge 1 commit intobenjaminkott:masterfrom
Open
Add highlighting support for conditions#3martin-helmich wants to merge 1 commit intobenjaminkott:masterfrom
martin-helmich wants to merge 1 commit intobenjaminkott:masterfrom
Conversation
This commit adds syntax highlighting support for TypoScript conditions (both legacy conditions and the new Symfony expressions) in both .typoscript and .tsconfig files. The regular expressions used to match the tokens of the Symfony expression language have been adapted from the original Symfony expression language repo (MIT licensed) [1]. [1]: https://github.com/symfony/expression-language/blob/master/Lexer.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @benjaminkott! 👋 Thanks for this VS code plugin! It has been immeasurably helpful for me so far. 🎉
I noticed that this plugin does not yet support syntax highlighting for TypoScript conditions, and even breaks completely on the new Symfony expression conditions:
This PR adds full syntax highlighting support for TypoScript conditions (both using the legacy syntax and the new Symfony expressions) in both
.typoscriptand.tsconfigfiles:Hope this contribution proves useful. 😉 Cheers!
Martin
Attribution:
The regular expressions used to match the tokens of the Symfony expression language have been adapted from the original Symfony expression language repo (MIT licensed) 1.