Add fee rate validation with 1000 sat/vbyte max

Author: kwsantiago

ddk-node/src/command.rs

@@ -142,6 +142,9 @@ pub async fn cli_command(
                 amount,
                 fee_rate,
             } => {
+                if fee_rate > 1000 {
+                    return Err(anyhow!("Fee rate too high: {} sat/vbyte (max: 1000)", fee_rate));
+                }
                 let txid = client
                     .send(SendRequest {
                         address,
@@ -330,6 +333,9 @@ async fn interactive_contract_input(
                 .prompt()?
                 .parse()?;
             let fee_rate: u64 = Text::new("Fee rate (sats/vbyte):").prompt()?.parse()?;
+            if fee_rate > 1000 {
+                return Err(anyhow!("Fee rate too high: {} sat/vbyte (max: 1000)", fee_rate));
+            }
             let min_price: u64 = Text::new("Minimum Bitcoin price:").prompt()?.parse()?;
             let max_price: u64 = Text::new("Maximum Bitcoin price:").prompt()?.parse()?;
             let num_steps: u64 = Text::new("Number of rounding steps:").prompt()?.parse()?;
@@ -372,6 +378,9 @@ async fn interactive_contract_input(
                 outcome_payouts.push(outcome_payout);
             }
             let fee_rate: u64 = Text::new("Fee rate (sats/vbyte):").prompt()?.parse()?;
+            if fee_rate > 1000 {
+                return Err(anyhow!("Fee rate too high: {} sat/vbyte (max: 1000)", fee_rate));
+            }
             // TODO: list possible events.
             ddk_payouts::enumeration::create_contract_input(
                 outcome_payouts,

ddk-node/src/lib.rs

@@ -144,7 +144,19 @@ impl DdkRpc for DdkNode {
             counter_party,
         } = request.into_inner();
         let contract_input: ContractInput =
-            serde_json::from_slice(&contract_input).expect("couldn't get bytes correct");
+            serde_json::from_slice(&contract_input).map_err(|e| {
+                Status::new(
+                    Code::InvalidArgument,
+                    format!("Invalid contract input: {}", e),
+                )
+            })?;
+
+        if contract_input.fee_rate > 1000 {
+            return Err(Status::new(
+                Code::InvalidArgument,
+                format!("Fee rate too high: {} sat/vbyte (max: 1000)", contract_input.fee_rate),
+            ));
+        }
         let mut oracle_announcements = Vec::new();
         for info in &contract_input.contract_infos {
             let announcement = self
@@ -336,6 +348,14 @@ impl DdkRpc for DdkNode {
             amount,
             fee_rate,
         } = request.into_inner();
+
+        if fee_rate > 1000 {
+            return Err(Status::new(
+                Code::InvalidArgument,
+                format!("Fee rate too high: {} sat/vbyte (max: 1000)", fee_rate),
+            ));
+        }
+
         let address = Address::from_str(&address).unwrap().assume_checked();
         let amount = Amount::from_sat(amount);
         let fee_rate = match FeeRate::from_sat_per_vb(fee_rate) {