Fix inspect.getsourcelines() indexing bug in --spew trace hook#3495
Open
veeceey wants to merge 1 commit into
Open
Fix inspect.getsourcelines() indexing bug in --spew trace hook#3495veeceey wants to merge 1 commit into
veeceey wants to merge 1 commit into
Conversation
Fix crash when using --spew with code that has no __file__ in globals (e.g. dynamically generated code from the attrs library). inspect.getsourcelines() returns a tuple (lines_list, start_lineno). The old code indexed this tuple directly with the frame's line number (src[lineno]), which caused: - AttributeError: 'int' object has no attribute 'rstrip' when lineno=1 (src[1] returns the integer start_lineno) - IndexError: tuple index out of range for lineno >= 2 The fix properly unpacks the tuple and offsets into the lines list: src_lines[lineno - src_start] Also catches IndexError in addition to OSError to gracefully handle any edge cases where the offset falls outside the source lines. Fixes benoitc#3344 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.