Skip to content

fix: resolve dockerfile_template with secure=False during containerize #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhishek8108 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: resolve dockerfile_template with secure=False during containerize #5596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a13c5f
fix: resolve dockerfile_template with secure=False during containerize
Abhishek8108 Apr 9, 2026
325ed55
ci: auto fixes from pre-commit.ci
pre-commit-ci[bot] Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/bentoml/_internal/container/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,9 @@ def generate_containerfile(

user_templates = docker.dockerfile_template
if user_templates is not None:
dir_path = os.path.dirname(resolve_user_filepath(user_templates, build_ctx))
dir_path = os.path.dirname(
resolve_user_filepath(user_templates, build_ctx, secure=False)
)
user_templates = os.path.basename(user_templates)
TEMPLATES_PATH.append(dir_path)
environment = ENVIRONMENT.overlay(
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/_internal/container/test_generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,30 @@
from bentoml._internal.container.generate import generate_containerfile


def test_generate_containerfile_dockerfile_template_outside_cwd(tmp_path) -> None:
# Regression test for https://github.com/bentoml/BentoML/issues/5566.
# During `bentoml containerize` the build context is a BentoML-managed temp
# directory (not under os.getcwd()), so resolve_user_filepath must be called
# with secure=False — otherwise it raises ValueError for any /tmp path.
template_dir = tmp_path / "env" / "docker"
template_dir.mkdir(parents=True)
(template_dir / "Dockerfile.template").write_text(
"{% extends bento_base_template %}\n"
)

# Must not raise ValueError even though tmp_path is outside os.getcwd()
generate_containerfile(
DockerOptions(
distro="debian",
python_version="3.11",
dockerfile_template="env/docker/Dockerfile.template",
),
str(tmp_path),
conda=CondaOptions(),
bento_fs=tmp_path,
)


def test_generate_containerfile_quotes_system_packages(tmp_path) -> None:
dockerfile = generate_containerfile(
DockerOptions(
Expand Down