fix: remove is_main guard on pickle content-type check to protect all…#5610
Open
ChristinaSaikoy wants to merge 1 commit into
Open
fix: remove is_main guard on pickle content-type check to protect all…#5610ChristinaSaikoy wants to merge 1 commit into
ChristinaSaikoy wants to merge 1 commit into
Conversation
… services The pickle deserialization protection in api_endpoint() only applies when is_main=True. Non-entry services in multi-service deployments have is_main=False (the default), leaving them vulnerable to RCE via unauthenticated pickle.loads() on user-controlled request bodies. Remove the is_main condition so ALL services block the unsafe application/vnd.bentoml+pickle content type. CWE-502: Deserialization of Untrusted Data
Author
|
Friendly ping @jianshen92 — this PR has been open for a week. Is there anything I can do to help move the review forward? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… services
The pickle deserialization protection in api_endpoint() only applies when is_main=True. Non-entry services in multi-service deployments have is_main=False (the default), leaving them vulnerable to RCE via unauthenticated pickle.loads() on user-controlled request bodies.
Remove the is_main condition so ALL services block the unsafe application/vnd.bentoml+pickle content type.
CWE-502: Deserialization of Untrusted Data
What does this PR address?
Fixes #(issue)
Before submitting:
guide on how to create a pull request.
pre-commit run -ascript has passed (instructions)?those accordingly? Here are documentation guidelines and tips on writting docs.