Skip to content

fix: remove is_main guard on pickle content-type check to protect all… #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristinaSaikoy wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: remove is_main guard on pickle content-type check to protect all… #5610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/_bentoml_impl/server/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,7 @@ async def api_endpoint(self, name: str, request: Request) -> Response:
media_type = media_type.split(";")[0].strip()

# NOTE: The following check is for security concern, DO NOT REMOVE
if self.is_main and media_type == "application/vnd.bentoml+pickle":
if media_type == "application/vnd.bentoml+pickle":
raise BentoMLException(
"application/vnd.bentoml+pickle is not allowed in main server",
error_code=HTTPStatus.UNSUPPORTED_MEDIA_TYPE,
Expand Down