test: add unit tests for the unflatten utility#5651
Closed
eeshsaxena wants to merge 1 commit into
Closed
Conversation
Adds coverage for _internal/utils/unflatten.py, which was previously untested. Covers nested dicts, lists, lists of lists, lists of dicts, sequence-of-pairs input, quoted keys, and the error paths (conflicting container/terminal types, missing list indices, and non-string keys). Signed-off-by: eeshsaxena <eeshsaxena@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a unit test suite for
bentoml/_internal/utils/unflatten.py, which previously had no test coverage anywhere in the suite.unflattenturns flat dotted/bracketed keys into nested structures, and it has quite a few branches worth pinning down. The newtests/unit/_internal/utils/test_unflatten.pycovers:{"foo.bar": "val"}→{"foo": {"bar": "val"}})(key, value)pairs, not just a dictTests only; no library code changed. Runs green locally (
17 passed) andruff check/ruff format --checkare clean on the file.Before submitting: