Skip to content

security: validate alias paths in list_bento to prevent path traversal #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kolega-ai-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

security: validate alias paths in list_bento to prevent path traversal #1219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/openllm/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from __future__ import annotations

import re, typing, json
import pathlib, re, typing, json
import tabulate, questionary, typer

from openllm.accelerator_spec import can_run
Expand Down Expand Up @@ -160,6 +160,12 @@ def list_bento(
with open(path) as f:
origin_name = f.read().strip()
origin_path = path.parent / origin_name
if '..' in pathlib.PurePosixPath(origin_name).parts:
continue
try:
origin_path.resolve().relative_to(repo.path.resolve())
except ValueError:
continue
model = BentoInfo(alias=path.name, repo=repo, path=origin_path)
else:
model = None
Expand Down