while we're here, let's trim out some unnecessary attributes for the voxel demo that we touched...

Author: RossNordby

Demos/Demos/CustomVoxelCollidableDemo.cs

@@ -108,7 +108,6 @@ unsafe struct HitLeafTester<T> : IRayLeafTester where T : IShapeRayHitHandler
         public Matrix3x3 Orientation;
         public RayData OriginalRay;
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public void TestLeaf(int leafIndex, RayData* ray, float* maximumT, BufferPool pool)
         {
             ref var voxelIndex = ref VoxelIndices[leafIndex];
@@ -179,7 +178,6 @@ public readonly unsafe void RayTest<TRayHitHandler>(in RigidPose pose, ref RaySo
         hitHandler = leafTester.HitHandler;
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public readonly void GetLocalChild(int childIndex, out Box childShape)
     {
         var halfSize = VoxelSize * 0.5f;
@@ -188,14 +186,12 @@ public readonly void GetLocalChild(int childIndex, out Box childShape)
         childShape.HalfLength = halfSize.Z;
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public readonly void GetPosedLocalChild(int childIndex, out Box childShape, out RigidPose childPose)
     {
         GetLocalChild(childIndex, out childShape);
         childPose = (VoxelIndices[childIndex] + new Vector3(0.5f) * VoxelSize);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public readonly void GetLocalChild(int childIndex, ref BoxWide shapeWide)
     {
         //This function provides a reference to a lane in an AOSOA structure.
@@ -207,7 +203,6 @@ public readonly void GetLocalChild(int childIndex, ref BoxWide shapeWide)
     }
 
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public readonly unsafe void FindLocalOverlaps<TOverlaps, TSubpairOverlaps>(ref Buffer<OverlapQueryForPair> pairs, BufferPool pool, Shapes shapes, ref TOverlaps overlaps)
          where TOverlaps : struct, ICollisionTaskOverlaps<TSubpairOverlaps>
          where TSubpairOverlaps : struct, ICollisionTaskSubpairOverlaps
@@ -228,7 +223,6 @@ public readonly unsafe void FindLocalOverlaps<TOverlaps, TSubpairOverlaps>(ref B
         }
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public readonly void FindLocalOverlaps<TEnumerator>(Vector3 min, Vector3 max, BufferPool pool, Shapes shapes, ref TEnumerator enumerator)
         where TEnumerator : IBreakableForEach<int>
     {
@@ -264,15 +258,13 @@ public struct ConvexVoxelsContinuations : IConvexCompoundContinuationHandler<Non
 {
     public CollisionContinuationType CollisionContinuationType => CollisionContinuationType.NonconvexReduction;
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public ref NonconvexReduction CreateContinuation<TCallbacks>(
         ref CollisionBatcher<TCallbacks> collisionBatcher, int childCount, in BoundsTestedPair pair, in OverlapQueryForPair pairQuery, out int continuationIndex)
         where TCallbacks : struct, ICollisionCallbacks
     {
         return ref collisionBatcher.NonconvexReductions.CreateContinuation(childCount, collisionBatcher.Pool, out continuationIndex);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static unsafe void GetChildData<TCallbacks>(ref CollisionBatcher<TCallbacks> collisionBatcher, ref NonconvexReductionChild continuationChild,
         in BoundsTestedPair pair, int shapeTypeA, int childIndexB, out RigidPose childPoseB, out int childTypeB, out void* childShapeDataB)
         where TCallbacks : struct, ICollisionCallbacks
@@ -295,7 +287,6 @@ public static unsafe void GetChildData<TCallbacks>(ref CollisionBatcher<TCallbac
         collisionBatcher.CacheShapeB(shapeTypeA, childTypeB, Unsafe.AsPointer(ref halfSize), 12, out childShapeDataB);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public unsafe void ConfigureContinuationChild<TCallbacks>(
         ref CollisionBatcher<TCallbacks> collisionBatcher, ref NonconvexReduction continuation, int continuationChildIndex, in BoundsTestedPair pair, int shapeTypeA, int childIndexB,
         out RigidPose childPoseB, out int childTypeB, out void* childShapeDataB)
@@ -327,15 +318,13 @@ public unsafe struct CompoundVoxelsContinuations<TCompoundA> : ICompoundPairCont
 {
     public CollisionContinuationType CollisionContinuationType => CollisionContinuationType.NonconvexReduction;
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public ref NonconvexReduction CreateContinuation<TCallbacks>(
         ref CollisionBatcher<TCallbacks> collisionBatcher, int totalChildCount, ref Buffer<ChildOverlapsCollection> pairOverlaps, ref Buffer<OverlapQueryForPair> pairQueries, in BoundsTestedPair pair, out int continuationIndex)
         where TCallbacks : struct, ICollisionCallbacks
     {
         return ref collisionBatcher.NonconvexReductions.CreateContinuation(totalChildCount, collisionBatcher.Pool, out continuationIndex);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public void GetChildAData<TCallbacks>(ref CollisionBatcher<TCallbacks> collisionBatcher, ref NonconvexReduction continuation, in BoundsTestedPair pair, int childIndexA,
         out RigidPose childPoseA, out int childTypeA, out void* childShapeDataA)
         where TCallbacks : struct, ICollisionCallbacks
@@ -347,7 +336,6 @@ public void GetChildAData<TCallbacks>(ref CollisionBatcher<TCallbacks> collision
         collisionBatcher.Shapes[childTypeA].GetShapeData(compoundChildA.ShapeIndex.Index, out childShapeDataA, out _);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public void ConfigureContinuationChild<TCallbacks>(
         ref CollisionBatcher<TCallbacks> collisionBatcher, ref NonconvexReduction continuation, int continuationChildIndex, in BoundsTestedPair pair, int childIndexA, int childTypeA, int childIndexB, in RigidPose childPoseA,
         out RigidPose childPoseB, out int childTypeB, out void* childShapeDataB)