Merge pull request #58 from berger-engineering-io/feat/plugin-openapi-lint-target

Author: michaelbe812

packages/plugin-openapi/project.json

@@ -28,6 +28,9 @@
         "packageRoot": "dist/{projectRoot}"
       }
     },
+    "lint": {
+      "executor": "@nx/eslint:lint"
+    },
     "test": {
       "executor": "@nx/jest:jest",
       "outputs": ["{workspaceRoot}/coverage/{projectRoot}"],

packages/plugin-openapi/src/lib/openapi-tools-generator.spec.ts

@@ -1,8 +1,11 @@
 import { spawn } from 'node:child_process';
 import { EventEmitter } from 'node:events';
 import { OpenApiToolsGenerator } from './openapi-tools-generator';
-import { buildCommandArgs } from './utils/build-command';
-import { GeneratorContext } from '@nx-plugin-openapi/core';
+import {
+  buildCommandArgs,
+  OpenApiGeneratorOptions,
+} from './utils/build-command';
+import { GenerateOptionsBase, GeneratorContext } from '@nx-plugin-openapi/core';
 
 // Mock node:child_process
 jest.mock('node:child_process', () => ({
@@ -14,10 +17,17 @@ jest.mock('./utils/build-command', () => ({
   buildCommandArgs: jest.fn(),
 }));
 
+type MockChildProcess = EventEmitter & { on: jest.Mock };
+type GeneratorWithCleanOutput = {
+  cleanOutput: (...args: unknown[]) => unknown;
+};
+
 describe('OpenApiToolsGenerator', () => {
   let generator: OpenApiToolsGenerator;
   let mockContext: GeneratorContext;
-  let mockChildProcess: any;
+  let mockChildProcess: MockChildProcess;
+  let generatorWithCleanOutput: GeneratorWithCleanOutput;
+  let cleanOutputSpy: jest.SpyInstance;
 
   beforeEach(() => {
     jest.clearAllMocks();
@@ -28,7 +38,7 @@ describe('OpenApiToolsGenerator', () => {
     };
 
     // Create a mock child process
-    mockChildProcess = new EventEmitter();
+    mockChildProcess = new EventEmitter() as MockChildProcess;
     mockChildProcess.on = jest.fn(mockChildProcess.on.bind(mockChildProcess));
     (spawn as jest.Mock).mockReturnValue(mockChildProcess);
 
@@ -42,7 +52,10 @@ describe('OpenApiToolsGenerator', () => {
     ]);
 
     // Mock cleanOutput method
-    jest.spyOn(generator as any, 'cleanOutput').mockImplementation(() => {});
+    generatorWithCleanOutput = generator as unknown as GeneratorWithCleanOutput;
+    cleanOutputSpy = jest
+      .spyOn(generatorWithCleanOutput, 'cleanOutput')
+      .mockImplementation(() => {});
   });
 
   describe('name', () => {
@@ -69,7 +82,7 @@ describe('OpenApiToolsGenerator', () => {
 
         await generatePromise;
 
-        expect((generator as any).cleanOutput).toHaveBeenCalledWith(
+        expect(cleanOutputSpy).toHaveBeenCalledWith(
           mockContext,
           'src/generated'
         );
@@ -176,31 +189,31 @@ describe('OpenApiToolsGenerator', () => {
           generatorOptions: {
             generator: 'typescript-axios',
           },
-        } as any;
+        } as unknown as OpenApiGeneratorOptions & GenerateOptionsBase;
 
         const generatePromise = generator.generate(options, mockContext);
 
         // Simulate successful execution for all three
         const emitClose = () => mockChildProcess.emit('close', 0);
         await emitClose();
-        await new Promise(resolve => setTimeout(resolve, 0));
+        await new Promise((resolve) => setTimeout(resolve, 0));
         await emitClose();
-        await new Promise(resolve => setTimeout(resolve, 0));
+        await new Promise((resolve) => setTimeout(resolve, 0));
         await emitClose();
 
         await generatePromise;
 
         // Should clean output for each service
-        expect((generator as any).cleanOutput).toHaveBeenCalledTimes(3);
-        expect((generator as any).cleanOutput).toHaveBeenCalledWith(
+        expect(cleanOutputSpy).toHaveBeenCalledTimes(3);
+        expect(cleanOutputSpy).toHaveBeenCalledWith(
           mockContext,
           'src/api/users'
         );
-        expect((generator as any).cleanOutput).toHaveBeenCalledWith(
+        expect(cleanOutputSpy).toHaveBeenCalledWith(
           mockContext,
           'src/api/products'
         );
-        expect((generator as any).cleanOutput).toHaveBeenCalledWith(
+        expect(cleanOutputSpy).toHaveBeenCalledWith(
           mockContext,
           'src/api/orders'
         );
@@ -234,7 +247,7 @@ describe('OpenApiToolsGenerator', () => {
             products: 'products.yaml',
           },
           outputPath: 'src/api',
-        } as any;
+        } as unknown as OpenApiGeneratorOptions & GenerateOptionsBase;
 
         const generatePromise = generator.generate(options, mockContext);
 
@@ -254,7 +267,7 @@ describe('OpenApiToolsGenerator', () => {
             'product-service': 'specs/products.yaml',
           },
           outputPath: 'generated',
-        } as any;
+        } as unknown as OpenApiGeneratorOptions & GenerateOptionsBase;
 
         const generatePromise = generator.generate(options, mockContext);
 

packages/plugin-openapi/src/lib/utils/build-command.spec.ts

@@ -204,8 +204,8 @@ describe('buildCommandArgs', () => {
       const options: OpenApiGeneratorOptions = {
         inputSpec: 'api.yaml',
         outputPath: 'output',
-        auth: null as any,
-        packageName: null as any,
+        auth: null as unknown as string,
+        packageName: null as unknown as string,
       };
 
       const result = buildCommandArgs(options);

packages/plugin-openapi/src/lib/utils/build-command.ts

@@ -81,8 +81,11 @@ export function buildCommandArgs(options: OpenApiGeneratorOptions): string[] {
   args.push('-g', 'typescript-angular');
   args.push('-o', options.outputPath!);
 
-  for (const [optionKey, flagConfig] of Object.entries(OPTION_FLAG_MAP)) {
-    const value = (options as any)[optionKey];
+  for (const [optionKey, flagConfig] of Object.entries(OPTION_FLAG_MAP) as [
+    keyof OpenApiGeneratorOptions,
+    FlagConfig | string
+  ][]) {
+    const value = options[optionKey] as unknown;
     if (
       value === undefined ||
       value === null ||