chore(hey-openapi): make generator and tests lint-compliant and rely on virtual mock for @hey-api/openapi-ts

Author: Mac Mini

packages/plugin-hey-openapi/src/lib/hey-openapi-generator.spec.ts

@@ -1,9 +1,13 @@
 import { HeyOpenApiGenerator } from './hey-openapi-generator';
 import { GeneratorContext } from '@nx-plugin-openapi/core';
 
-jest.mock('@hey-api/openapi-ts', () => ({
-  generate: jest.fn(async () => undefined),
-}));
+jest.mock(
+  '@hey-api/openapi-ts',
+  () => ({
+    generate: jest.fn(async () => undefined),
+  }),
+  { virtual: true }
+);
 
 describe('HeyOpenApiGenerator', () => {
   let generator: HeyOpenApiGenerator;
@@ -28,19 +32,21 @@ describe('HeyOpenApiGenerator', () => {
   });
 
   it('should call openapi-ts generate for single spec', async () => {
-    const { generate } = (await import('@hey-api/openapi-ts')) as any;
+    const mod = (await import('@hey-api/openapi-ts')) as unknown as {
+      generate: jest.Mock;
+    };
 
     await generator.generate(
       {
         inputSpec: 'api.yaml',
         outputPath: 'src/generated',
         generatorOptions: { client: 'fetch' },
-      } as any,
+      } as unknown as Parameters<HeyOpenApiGenerator['generate']>[0],
       mockContext
     );
 
     expect(cleanOutputSpy).toHaveBeenCalledWith(mockContext, 'src/generated');
-    expect(generate).toHaveBeenCalledWith(
+    expect(mod.generate).toHaveBeenCalledWith(
       expect.objectContaining({
         input: 'api.yaml',
         output: '/workspace/src/generated',
@@ -50,25 +56,27 @@ describe('HeyOpenApiGenerator', () => {
   });
 
   it('should call openapi-ts generate for multiple specs', async () => {
-    const { generate } = (await import('@hey-api/openapi-ts')) as any;
+    const mod = (await import('@hey-api/openapi-ts')) as unknown as {
+      generate: jest.Mock;
+    };
 
     await generator.generate(
       {
         inputSpec: { users: 'users.yaml', products: 'products.yaml' },
         outputPath: 'src/api',
-      } as any,
+      } as unknown as Parameters<HeyOpenApiGenerator['generate']>[0],
       mockContext
     );
 
     expect(cleanOutputSpy).toHaveBeenCalledTimes(2);
-    expect(generate).toHaveBeenCalledTimes(2);
-    expect(generate).toHaveBeenCalledWith(
+    expect(mod.generate).toHaveBeenCalledTimes(2);
+    expect(mod.generate).toHaveBeenCalledWith(
       expect.objectContaining({
         input: 'users.yaml',
         output: '/workspace/src/api/users',
       })
     );
-    expect(generate).toHaveBeenCalledWith(
+    expect(mod.generate).toHaveBeenCalledWith(
       expect.objectContaining({
         input: 'products.yaml',
         output: '/workspace/src/api/products',

packages/plugin-hey-openapi/src/lib/hey-openapi-generator.ts

@@ -31,14 +31,11 @@ export class HeyOpenApiGenerator
 
     if (typeof inputSpec === 'string') {
       this.cleanOutput(ctx, outputPath);
-      await this.invokeOpenApiTs(
-        {
-          input: inputSpec,
-          output: join(ctx.root, outputPath),
-          ...generatorOptions,
-        },
-        ctx
-      );
+      await this.invokeOpenApiTs({
+        input: inputSpec,
+        output: join(ctx.root, outputPath),
+        ...generatorOptions,
+      });
     } else {
       const entries = Object.entries(inputSpec as Record<string, string>) as [
         string,
@@ -51,23 +48,19 @@ export class HeyOpenApiGenerator
         logger.info(`Generating service: ${serviceName}`);
         const serviceOutputPath = join(outputPath, serviceName);
         this.cleanOutput(ctx, serviceOutputPath);
-        await this.invokeOpenApiTs(
-          {
-            input: specPath,
-            output: join(ctx.root, serviceOutputPath),
-            ...generatorOptions,
-          },
-          ctx
-        );
+        await this.invokeOpenApiTs({
+          input: specPath,
+          output: join(ctx.root, serviceOutputPath),
+          ...generatorOptions,
+        });
       }
     }
 
     logger.info(`hey-openapi code generation completed successfully`);
   }
 
   private async invokeOpenApiTs(
-    config: { input: string; output: string } & Record<string, unknown>,
-    _ctx: GeneratorContext
+    config: { input: string; output: string } & Record<string, unknown>
   ): Promise<void> {
     let mod: Record<string, unknown>;
     try {
@@ -79,11 +72,16 @@ export class HeyOpenApiGenerator
       );
     }
 
+    const generateExport = (mod as Record<string, unknown>)['generate'];
+    const createClientExport = (mod as Record<string, unknown>)['createClient'];
+
     const fn =
-      typeof (mod as any).generate === 'function'
-        ? ((mod as any).generate as (cfg: unknown) => Promise<unknown>)
-        : typeof (mod as any).createClient === 'function'
-        ? ((mod as any).createClient as (cfg: unknown) => Promise<unknown>)
+      typeof generateExport === 'function'
+        ? (generateExport as (cfg: Record<string, unknown>) => Promise<unknown>)
+        : typeof createClientExport === 'function'
+        ? (createClientExport as (
+            cfg: Record<string, unknown>
+          ) => Promise<unknown>)
         : undefined;
 
     if (!fn) {
@@ -95,7 +93,7 @@ export class HeyOpenApiGenerator
       );
     }
 
-    await fn(config);
+    await fn(config as Record<string, unknown>);
   }
 }