Skip to content

Commit 84477ad

Browse files
committed
Address review comments
1 parent 5f6f1c5 commit 84477ad

2 files changed

Lines changed: 4 additions & 18 deletions

File tree

temporal-test-server/src/main/java/io/temporal/internal/testservice/StateMachines.java

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -807,20 +807,6 @@ private static void timeoutNexusOperation(
807807
"Timeout type not supported for Nexus operations: " + timeoutType);
808808
}
809809

810-
String timeoutMessage;
811-
switch (timeoutType) {
812-
case TIMEOUT_TYPE_SCHEDULE_TO_START:
813-
timeoutMessage = "operation timed out before starting";
814-
break;
815-
case TIMEOUT_TYPE_START_TO_CLOSE:
816-
timeoutMessage = "operation timed out after starting";
817-
break;
818-
case TIMEOUT_TYPE_SCHEDULE_TO_CLOSE:
819-
default:
820-
timeoutMessage = "operation timed out";
821-
break;
822-
}
823-
824810
Failure failure =
825811
Failure.newBuilder()
826812
.setMessage("nexus operation completed unsuccessfully")
@@ -833,7 +819,7 @@ private static void timeoutNexusOperation(
833819
.setScheduledEventId(data.scheduledEventId))
834820
.setCause(
835821
Failure.newBuilder()
836-
.setMessage(timeoutMessage)
822+
.setMessage("operation timed out")
837823
.setTimeoutFailureInfo(
838824
TimeoutFailureInfo.newBuilder().setTimeoutType(timeoutType)))
839825
.build();

temporal-test-server/src/test/java/io/temporal/testserver/functional/NexusWorkflowTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,7 @@ public void testNexusOperationScheduleToStartTimeout() {
745745
Assert.assertTrue("OPERATION_TIMEOUT should be positive", operationTimeoutMs > 0);
746746

747747
// Sleep longer than schedule-to-start timeout to trigger the timeout
748-
Thread.sleep(2000);
748+
testWorkflowRule.sleep(2000);
749749
} catch (Exception e) {
750750
Assert.fail(e.getMessage());
751751
}
@@ -763,7 +763,7 @@ public void testNexusOperationScheduleToStartTimeout() {
763763
assertOperationFailureInfo(failure.getNexusOperationExecutionFailureInfo());
764764
Assert.assertEquals("nexus operation completed unsuccessfully", failure.getMessage());
765765
io.temporal.api.failure.v1.Failure cause = failure.getCause();
766-
Assert.assertEquals("operation timed out before starting", cause.getMessage());
766+
Assert.assertEquals("operation timed out", cause.getMessage());
767767
Assert.assertTrue(cause.hasTimeoutFailureInfo());
768768
Assert.assertEquals(
769769
TimeoutType.TIMEOUT_TYPE_SCHEDULE_TO_START, cause.getTimeoutFailureInfo().getTimeoutType());
@@ -833,7 +833,7 @@ public void testNexusOperationStartToCloseTimeout() {
833833
assertOperationFailureInfo(operationId, failure.getNexusOperationExecutionFailureInfo());
834834
Assert.assertEquals("nexus operation completed unsuccessfully", failure.getMessage());
835835
io.temporal.api.failure.v1.Failure cause = failure.getCause();
836-
Assert.assertEquals("operation timed out after starting", cause.getMessage());
836+
Assert.assertEquals("operation timed out", cause.getMessage());
837837
Assert.assertTrue(cause.hasTimeoutFailureInfo());
838838
Assert.assertEquals(
839839
TimeoutType.TIMEOUT_TYPE_START_TO_CLOSE, cause.getTimeoutFailureInfo().getTimeoutType());

0 commit comments

Comments
 (0)