try to tweak CI config

Author: cycomachead

.github/workflows/rspec.yml

@@ -7,11 +7,12 @@ on:
 
 jobs:
   rspec:
-    runs-on: ubuntu-24.04
+    runs-on: ubuntu-latest
     services:
       postgres:
         image: postgres:17
         env:
+          POSTGRES_USER: postgres
           POSTGRES_PASSWORD: password
         ports:
           - 5432:5432
@@ -20,10 +21,9 @@ jobs:
     env:
       # Do not install production/staging-only gems in test environment
       BUNDLE_WITHOUT: "production staging"
+      DB_HOST: localhost
       DB_USER: postgres
       DB_PASSWORD: password
-      RAILS_ENV: test
-      RUBY_ENV: test
       # TODO: This should not be required, but a few specs rely on it by using ENV.fetch.
       CANVAS_URL: https://ucberkeleysandbox.instructure.com
       CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}

.github/workflows/rubocop.yml

@@ -1,12 +1,12 @@
-name: RuboCop
+name: Checks
 
 on:
   push:
   pull_request:
   workflow_dispatch:
 
 jobs:
-  scan:
+  brakeman:
     runs-on: ubuntu-latest
     env:
       # Do not install production/staging-only gems in test environment

app/controllers/courses_controller.rb

@@ -32,9 +32,9 @@ def show
     end
 
     @assignments = if @role == 'student'
-                     Assignment.where(course_to_lms_id: course_to_lms.id, enabled: true).order(:name)
+      Assignment.where(course_to_lms_id: course_to_lms.id, enabled: true).order(:name)
     else
-                     Assignment.where(course_to_lms_id: course_to_lms.id).order(:name)
+      Assignment.where(course_to_lms_id: course_to_lms.id).order(:name)
     end
     render_role_based_view
   end

spec/rails_helper.rb

@@ -2,6 +2,10 @@
 require 'spec_helper'
 ENV['RAILS_ENV'] ||= 'test'
 
+# Ensure there is always a CANVAS_URL present.
+# This is somewhat of an anti-pattern.
+ENV['CANVAS_URL'] ||= 'https://ucberkeleysandbox.instructure.com'
+
 require_relative '../config/environment'
 
 # Prevent database truncation if the environment is production

spec/spec_helper.rb

@@ -33,6 +33,11 @@
   # Exclude accessibility tests by default
   config.filter_run_excluding :a11y
 
+  config.before do
+    # Ensure there is always a CANVAS_URL present.
+    # This is somewhat of an anti-pattern.
+    ENV['CANVAS_URL'] ||= 'https://ucberkeleysandbox.instructure.com'
+  end
   # rspec-expectations config goes here. You can use an alternate
   # assertion/expectation library such as wrong or the stdlib/minitest
   # assertions if you prefer.