Continued Gradescope Integration#78
Closed
cycomachead wants to merge 24 commits into
Closed
Conversation
Contributor
Author
|
The request controller and model are the first things that deserve serious refactoring
|
Contributor
Author
|
I suspect the initializer broke tests. lets see if Claude is right |
* main: Use ruby 3.3.8 Update buildspec.yml Update buildspec.yml Update production.rb set config.hosts.clear and change SMTP config initial commit for flextensions staging
* errors for bad auth need to be explicit. * the facade Assignment class need to be aligned... ;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #58
Much of the app was written assuming there was 1 LMS.
We need to now enforce using the Facade patterns to almost all API access, especially when it comes to approval and denial of requests.