Skip to content

Commit 07109cc

Browse files
committed
spotbugs(OPM) suppress OPM_OVERLY_PERMISSIVE_METHOD project-wide
Defers the 25-site scope-tightening pass until after the planned package-architecture refactor. Same rationale and decision recorded in workspace/crossrepostatus.md alongside the parallel BAF suppression. Why suppress instead of fix now: - Current jllama package layout groups production code in net.ladenthin.llama + a thin sibling package set. Any method called only by same-package callers is flagged as "could be package-private". Correct today, false tomorrow once the refactor splits the root package into proper layers — cross-layer calls then need public. - Tightening every site now creates mechanical churn the refactor would revert. - TODO marker added to workspace/crossrepostatus.md under the "Affects BAF + jllama (multi-package repos)" section so the rule can be re-enabled deliberately the week the layers stabilise. Cross-repo alignment: same suppression added to BAF (BitcoinAddressFinder/spotbugs-exclude.xml, 33 sites there).
1 parent ce8b466 commit 07109cc

1 file changed

Lines changed: 28 additions & 0 deletions

File tree

spotbugs-exclude.xml

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,4 +205,32 @@ SPDX-License-Identifier: MIT
205205
<Bug pattern="USBR_UNNECESSARY_STORE_BEFORE_RETURN"/>
206206
</Match>
207207

208+
<!--
209+
fb-contrib OPM_OVERLY_PERMISSIVE_METHOD ("Method is declared more
210+
permissively than is used in the code base") suppressed PROJECT-WIDE.
211+
212+
Rationale (kept aligned cross-repo with BitcoinAddressFinder):
213+
- Current package layout groups most production Java in
214+
net.ladenthin.llama + a thin sibling package set. Any method
215+
called only from same-package callers is flagged as "could be
216+
package-private". Those answers are correct today but unstable:
217+
once the planned package-architecture refactor splits the root
218+
package into proper layers, methods that today are correctly
219+
package-private will need to become public to cross the new
220+
boundaries. Tightening now produces mechanical churn highly
221+
likely to be reverted by the refactor.
222+
223+
- Cross-repo decision + per-category breakdown recorded in
224+
workspace/crossrepostatus.md ("OPM scope-tightening — after
225+
package refactor"). The same rule is suppressed in BAF.
226+
227+
TODO: re-enable this rule (delete this Match block) once the
228+
package refactor has settled — at that point genuine "method
229+
exposed beyond its actual call site" findings become stable
230+
signals worth fixing.
231+
-->
232+
<Match>
233+
<Bug pattern="OPM_OVERLY_PERMISSIVE_METHOD"/>
234+
</Match>
235+
208236
</FindBugsFilter>

0 commit comments

Comments
 (0)