Commit 5624e83
committed
Close remaining doc staleness from PR #189 work
Three small gaps caught in a final audit of the §-doc and
the issues doc:
1. feature-investigation §1 'What java-llama.cpp already covers':
the Session row still read 'single-threaded'. PR #189 added
per-Session locking; relabel to 'thread-safe per instance'
so the §1 table matches the §2.6 status block.
2. feature-investigation §4 'Suggested rollout order': all ten
entries listed there are SHIPPED now. The section is preserved
as a historical artifact (useful for comparing original effort
estimates against what actually shipped, especially §2.1 which
came in much smaller than the L estimate and §2.10 which had
to be reverted), but a header note now states up front that it
is no longer a roadmap.
3. docs/history/49be664_open_issues.md #113 LoadProgressCallback:
the entry said FIXED in PR #188 and stopped there, but the
PR #188 implementation forgot the forward declaration in
jllama.h, which made the JNI symbol C++-mangled and produced
an UnsatisfiedLinkError on the first call to the feature.
PR #189 commit 36d8862 added the missing declaration and the
feature is now actually functional (LoadProgressCallbackTest
passes on the current CI). Add a 'Subtle issue resolved by
PR #189' paragraph so a future reader does not think 'PR #188
shipped this, why did it fail on the first run after merge'.
No code changes; documentation only.1 parent 0f597b3 commit 5624e83
2 files changed
Lines changed: 32 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
411 | 411 | | |
412 | 412 | | |
413 | 413 | | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
414 | 425 | | |
415 | 426 | | |
416 | 427 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
194 | | - | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
195 | 197 | | |
196 | 198 | | |
197 | 199 | | |
| |||
207 | 209 | | |
208 | 210 | | |
209 | 211 | | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
210 | 228 | | |
211 | 229 | | |
212 | 230 | | |
| |||
0 commit comments