Commit 65894f6
committed
Fix package phase: exclude module-info.java from gpu and opencl-android compile passes
The release profile chains three compile executions:
- default-compile -> release 8, excludes module-info.java
- module-info-compile -> release 9, includes only module-info.java
- gpu / opencl-android -> classifier-specific passes that write to
${project.build.outputDirectory}_cuda / _opencl_android
The gpu and opencl-android executions inherited <release>8</release>
from the plugin-level config but did NOT inherit default-compile's
<excludes>module-info.java</excludes>; Maven plugin executions are
independent. When triggered (mvn package -P release,cuda,opencl-android)
either pass picked up module-info.java and failed with
"modules are not supported in -source 8".
Added the same exclude block to both executions. Verified locally:
mvn -P release,cuda,opencl-android -Dmaven.test.skip=true package
now succeeds.
Also added a TODO for LlamaModel.getSuppressTokens() mirroring the new
llama_vocab::get_suppress_tokens() accessor from b9490->b9495. The bias
is auto-applied inside the model graph (Gemma4 Unified uses it to block
<image|>/<audio|> placeholders); a Java mirror would only be an inspector
for callers running their own sampling. Same posture as the existing
b9444->b9490 follow-up TODOs - add only on real user request.1 parent 03bcef1 commit 65894f6
2 files changed
Lines changed: 12 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
730 | 730 | | |
731 | 731 | | |
732 | 732 | | |
| 733 | + | |
| 734 | + | |
733 | 735 | | |
734 | 736 | | |
735 | 737 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
692 | 692 | | |
693 | 693 | | |
694 | 694 | | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
695 | 700 | | |
696 | 701 | | |
697 | 702 | | |
| |||
768 | 773 | | |
769 | 774 | | |
770 | 775 | | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
771 | 781 | | |
772 | 782 | | |
773 | 783 | | |
| |||
0 commit comments