Skip to content

Commit 7b8bfdb

Browse files
Merge pull request #141 from bernardladenthin/claude/add-pending-unit-test-R2tO3
Add tracking link for llama.cpp reasoning_budget_tokens bug
2 parents f354581 + ed49208 commit 7b8bfdb

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/test/java/net/ladenthin/llama/ReasoningBudgetTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ public void testThinkingDefault_reasoningContentAndAnswerPresent() {
120120
* <p>This assertion will start <b>failing</b> once the llama.cpp bug is fixed —
121121
* that is the signal to remove this test and enable
122122
* {@link #testReasoningBudgetZero_expectedBehavior_suppressesThinking}.
123+
* Tracked in <a href="https://github.com/ggml-org/llama.cpp/pull/23116">llama.cpp PR #23116</a>.
123124
*/
124125
@Test
125126
public void testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed() {
@@ -169,6 +170,7 @@ public void testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed() {
169170
* <p>Once this fix is applied: remove {@code @Ignore}, confirm this test passes,
170171
* and remove
171172
* {@link #testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed}.
173+
* Tracked in <a href="https://github.com/ggml-org/llama.cpp/pull/23116">llama.cpp PR #23116</a>.
172174
*/
173175
@Ignore("llama.cpp bug: per-request reasoning_budget_tokens is overwritten by model default " +
174176
"in oaicompat_chat_params_parse (server-common.cpp). " +

0 commit comments

Comments
 (0)