Add regression tests for issues #80, #95, #98, #102 (#185)

* test: add JUnit regressions for kherud open issues #80, #95, #98, #102

Adds four small JUnit tests proposed in the verification plan section of
docs/history/49be664_open_issues.md to upgrade the corresponding upstream
issues from LIKELY FIXED to FIXED:

- MemoryManagementTest#testOpenCloseLoopDoesNotLeak (#102) - 20-iteration
  open/close loop; on Linux asserts VmRSS delta < 200 MB. Degenerates to
  a no-crash smoke test on non-Linux hosts where /proc/self/status is
  absent.
- MemoryManagementTest#testOpenCloseWithoutGeneration (#80) - 20 open +
  immediate close without any generation, exercises the half-initialised
  worker race closed by the double server.terminate() in jllama.cpp.
- LlamaModelTest#testIteratorTerminatesOnRepetitivePrompt (#95) - asserts
  the iterator terminates within nPredict+1 steps on a deliberately
  repetitive prompt.
- LlamaEmbeddingsTest#testNomicEmbedLoads (#98) - gated on system
  property net.ladenthin.llama.nomic.path; reproduces the reporter's
  batch/ubatch config plus the fix (enableEmbedding()), and asserts a
  768-dim vector for nomic-embed-text-v1.5.

Wires up the optional nomic GGUF download in the linux-x86_64 Java test
job in .github/workflows/publish.yml. Other test jobs cleanly self-skip
via Assume because the system property is unset.

Documents the local native-build workflow in CLAUDE.md - per-host output
paths, mvn-cmake handoff, optional model handling, and the
restricted-network caveat for environments that block huggingface.co.

https://claude.ai/code/session_01LR7Gw1pyKS7wvxXfZjnxNW

* docs: record #80/#95/#98/#102 regression tests added in 713d426

Updates docs/history/49be664_open_issues.md to reflect that the four
JUnit regression tests called for in the verification plan have been
added on this branch:

- Deep-dive verdict guide now lists each test name and self-skip
  behaviour next to its issue bullet
- Per-issue Status blocks for #80, #95, #98, #102 annotated as
  "LIKELY FIXED -> FIXED on CI green" with the covering test
- Status overview table rows for the same four issues updated
- "What the original issues actually contain" feasibility table marks
  all four as DONE with the commit reference
- "Concrete test plan" gains a status callout noting the as-shipped
  implementation matches the sketches
- "Recommended sequencing" step 1 marked DONE and enumerates what
  shipped; remaining steps (#86 docs, #103/#34 typed image API, Android
  emulator CI) carried forward as the next deliverables

No code or behaviour change, documentation only.

https://claude.ai/code/session_01LR7Gw1pyKS7wvxXfZjnxNW

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: bernardladenthin

.github/workflows/publish.yml

@@ -20,6 +20,8 @@ env:
   DRAFT_MODEL_NAME: "AMD-Llama-135m-code.Q2_K.gguf"
   REASONING_MODEL_URL: "https://huggingface.co/unsloth/Qwen3-0.6B-GGUF/resolve/main/Qwen3-0.6B-Q4_K_M.gguf"
   REASONING_MODEL_NAME: "Qwen3-0.6B-Q4_K_M.gguf"
+  NOMIC_EMBED_MODEL_URL: "https://huggingface.co/nomic-ai/nomic-embed-text-v1.5-GGUF/resolve/main/nomic-embed-text-v1.5.f16.gguf"
+  NOMIC_EMBED_MODEL_NAME: "nomic-embed-text-v1.5.f16.gguf"
 permissions:
   contents: read
 jobs:
@@ -389,6 +391,8 @@ jobs:
         run: curl -L --fail ${DRAFT_MODEL_URL} --create-dirs -o models/${DRAFT_MODEL_NAME}
       - name: Download reasoning model
         run: curl -L --fail ${REASONING_MODEL_URL} --create-dirs -o models/${REASONING_MODEL_NAME}
+      - name: Download nomic embedding model (issue #98 regression)
+        run: curl -L --fail ${NOMIC_EMBED_MODEL_URL} --create-dirs -o models/${NOMIC_EMBED_MODEL_NAME}
       - name: List files in models directory
         run: ls -l models/
       - name: Validate model files
@@ -404,7 +408,7 @@ jobs:
           ulimit -c unlimited
           echo "${{ github.workspace }}/core.%e.%p" | sudo tee /proc/sys/kernel/core_pattern
       - name: Run tests
-        run: mvn --no-transfer-progress test
+        run: mvn --no-transfer-progress test -Dnet.ladenthin.llama.nomic.path=models/${NOMIC_EMBED_MODEL_NAME}
       - uses: actions/upload-artifact@v7
         if: success()
         with:

CLAUDE.md

@@ -431,6 +431,84 @@ cmake -B build -DLLAMA_CURL=ON
 
 Built libraries are placed in `src/main/resources/net/ladenthin/llama/{OS}/{ARCH}/`.
 
+### Building the native library for local Java tests
+
+`mvn test` does **not** build the native library — Maven only compiles Java
+and runs surefire. The shared library must already exist on disk under the
+platform-specific resource path that `LlamaLoader` resolves at runtime.
+Without it the JVM throws `UnsatisfiedLinkError` and every Java test fails
+immediately (it does not auto-skip).
+
+The output path is derived by `CMakeLists.txt` from `OS_NAME` and `OS_ARCH`
+detected by the helper script `.github/dockcross/dockcross-resolve-host`
+(falls back to `uname` on hosts where the script is absent). The mapping
+mirrors `OSInfo.translateOSNameToFolderName` on the Java side, so the same
+folder name is produced on both ends.
+
+| Host | Library file | Resource path produced by `cmake --build` |
+|------|--------------|-------------------------------------------|
+| Linux x86_64 | `libjllama.so` | `src/main/resources/net/ladenthin/llama/Linux/x86_64/` |
+| Linux aarch64 | `libjllama.so` | `src/main/resources/net/ladenthin/llama/Linux/aarch64/` |
+| macOS Apple Silicon | `libjllama.dylib` | `src/main/resources/net/ladenthin/llama/Mac/aarch64/` |
+| macOS Intel | `libjllama.dylib` | `src/main/resources/net/ladenthin/llama/Mac/x86_64/` |
+| Windows x86_64 | `jllama.dll` (+ `llama.dll`, `ggml.dll`) | `src/main/resources/net/ladenthin/llama/Windows/x86_64/` |
+
+The Windows `RUNTIME_OUTPUT_DIRECTORY_*` properties (`CMakeLists.txt:266-269`)
+deposit `jllama.dll` alongside the upstream `llama.dll` / `ggml.dll`; all
+three must remain co-located so the loader can resolve transitive imports.
+
+End-to-end local workflow for running Java tests:
+
+```bash
+# 1. Generate JNI headers (one-time per Java API change)
+mvn -q compile
+
+# 2. Configure + build the native library for the current host
+cmake -B build
+cmake --build build --config Release -j$(nproc)
+# The shared lib lands directly in src/main/resources/.../{OS}/{ARCH}/ —
+# no separate install step is needed.
+
+# 3. Ensure model files referenced by tests are present under models/.
+#    The default test models (downloaded by CI in publish.yml) are:
+curl -L --fail "$MODEL_URL"          --create-dirs -o models/codellama-7b.Q2_K.gguf
+curl -L --fail "$RERANKING_MODEL_URL" --create-dirs -o models/jina-reranker-v1-tiny-en-Q4_0.gguf
+curl -L --fail "$DRAFT_MODEL_URL"     --create-dirs -o models/AMD-Llama-135m-code.Q2_K.gguf
+curl -L --fail "$REASONING_MODEL_URL" --create-dirs -o models/Qwen3-0.6B-Q4_K_M.gguf
+
+# 4. Run tests. Tests that need a model file self-skip via Assume.assumeTrue()
+#    when their GGUF is absent, so partial model availability is OK.
+mvn test
+# CPU-only host (no GPU): pin GPU layers to 0
+mvn test -Dnet.ladenthin.llama.test.ngl=0
+# Run a single test class or method
+mvn test -Dtest=MemoryManagementTest
+mvn test -Dtest=LlamaModelTest#testGenerateAnswer
+```
+
+**Optional models** referenced by individual tests are gated on a system
+property so CI can skip them cleanly when the GGUF is not downloaded:
+
+| Property | Default test that uses it | Model |
+|----------|---------------------------|-------|
+| `net.ladenthin.llama.nomic.path` | `LlamaEmbeddingsTest#testNomicEmbedLoads` | `nomic-embed-text-v1.5.f16.gguf` (issue #98 regression) |
+
+Run those tests by setting the property:
+```bash
+mvn test -Dtest=LlamaEmbeddingsTest#testNomicEmbedLoads \
+         -Dnet.ladenthin.llama.nomic.path=models/nomic-embed-text-v1.5.f16.gguf
+```
+
+**Restricted-network environments.** Some hosts (e.g. ephemeral remote
+execution sandboxes) block outbound traffic to `huggingface.co`. In that
+case downloading models for the Java tests is not possible from the host
+itself; the native library can still be built and the C++ test suite
+(`ctest --test-dir build`) still runs because it depends only on the
+upstream sources fetched at CMake configure time. Java tests should then
+be exercised either in CI (via `.github/workflows/publish.yml`) or on a
+developer machine with HF access; pre-staged models can also be uploaded
+into `models/` out-of-band.
+
 ### Code Formatting
 ```bash
 clang-format -i src/main/cpp/*.cpp src/main/cpp/*.hpp   # Format C++ code