forked from kherud/java-llama.cpp
-
Notifications
You must be signed in to change notification settings - Fork 3
Upgrade llama.cpp from b9106 to b9134 #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3b01985
Upgrade llama.cpp from b9106 to b9134
claude 616d5d4
Add net_ladenthin_llama_*.h to .gitignore
claude a64e264
Replace de_kherud_llama_*.h with net_ladenthin_llama_*.h in .gitignore
claude d2ec0ed
Remove setCtxSizeDraft() call sites from tests
claude f1aecc1
Upgrade llama.cpp from b9134 to b9145
claude 79aecdf
Add tests for InferenceParameters.setContinueFinalMessage
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -243,9 +243,8 @@ TEST(SlotParamsToJson, SpeculativeFields_Present) { | |
| task_params p; | ||
| const json j = p.to_json(); | ||
|
|
||
| // b8962: only speculative.type is serialised; n_max/n_min/p_min are | ||
| // input-only (consumed by params_from_json_cmpl, not emitted by to_json) | ||
| EXPECT_TRUE(j.contains("speculative.type")); | ||
| // b9134: field renamed speculative.type → speculative.types (now a vector) | ||
| EXPECT_TRUE(j.contains("speculative.types")); | ||
| } | ||
|
Comment on lines
243
to
248
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct test update. The comment accurately reflects the b9134 API change (field renamed from |
||
|
|
||
| TEST(SlotParamsToJson, GrammarTriggers_IsArrayByDefault) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment indicates
speculative.typesis now a vector, but the test only checks that the field exists. Since the API change includes a type change from enum to vector, the assertion should verify the serialization format:This ensures the field isn't just present, but serialized correctly as a JSON array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion is incorrect —
speculative.typesis serialized as a comma-separated string, not a JSON array.common_speculative_type_name_str(incommon/speculative.cpp:794) returns astd::stringby iterating the vector and joining with",". Theto_json()call inserver-task.cpp:79therefore produces e.g."draft-simple"or"draft-simple,eagle3", sois_array()would fail on a default-constructedtask_params. Thecontainsassertion is sufficient and correct.Generated by Claude Code