Skip to content

Add tracking link for llama.cpp reasoning_budget_tokens bug #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardladenthin merged 1 commit into from
May 15, 2026
Merged

Add tracking link for llama.cpp reasoning_budget_tokens bug #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/test/java/net/ladenthin/llama/ReasoningBudgetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ public void testThinkingDefault_reasoningContentAndAnswerPresent() {
* <p>This assertion will start <b>failing</b> once the llama.cpp bug is fixed —
* that is the signal to remove this test and enable
* {@link #testReasoningBudgetZero_expectedBehavior_suppressesThinking}.
* Tracked in <a href="https://github.com/ggml-org/llama.cpp/pull/23116">llama.cpp PR #23116</a>.
*/
@Test
public void testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed() {
Expand Down Expand Up @@ -169,6 +170,7 @@ public void testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed() {
* <p>Once this fix is applied: remove {@code @Ignore}, confirm this test passes,
* and remove
* {@link #testReasoningBudgetZero_parameterAccepted_thinkingNotSuppressed}.
* Tracked in <a href="https://github.com/ggml-org/llama.cpp/pull/23116">llama.cpp PR #23116</a>.
*/
@Ignore("llama.cpp bug: per-request reasoning_budget_tokens is overwritten by model default " +
"in oaicompat_chat_params_parse (server-common.cpp). " +
Expand Down
Loading